Fixes #5574: Automatically force cf-serverd to reload its configuration #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Force cf-serverd to reload its promises | ||
| * It always succeeed, even if it fails it simply delays the reloading (automatic) by the server | ||
| */ | ||
| def reloadCFEnginePromises() : Box[String] = { |
There was a problem hiding this comment.
Could you make it returns Unit, so that we really know from the signature that the method is purilly side effecting, and that the result it not interesting ?
(since it's always Full(something)
ncharles
force-pushed
the
ust_5571/dev/5574_add_cfengine_reload_promises
branch
from
5c0f067
to
ecd2ec9
Compare
|
PR has been updated |
|
That seems ok for me. We will need a migration script for the new property. |
|
Please adjust the description of the property as discussed in Normation/rudder-packages#519 |
ncharles
force-pushed
the
ust_5571/dev/5574_add_cfengine_reload_promises
branch
from
ecd2ec9
to
08d8ce2
Compare
|
updated |
ncharles
added a commit
that referenced
this pull request
Nov 12, 2014
…reload_promises Fixes #5574: Automatically force cf-serverd to reload its configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.