Fixes #5732: Add migration script to add rudder.cfengine.reload.server.c... #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
must be merged with Normation/rudder#617 |
|
Looks good to me ! |
| STEP="Add the property to configure the command line to force the server to reload its promises" | ||
|
|
||
| check_and_add_config_property rudder.cfengine.reload.server.command " | ||
| # Command line to force the server to reload its promises |
There was a problem hiding this comment.
Please remove "line". It's a command, not a command line (a command line is where you type the command into)
Could you please also clarify when this is executed by the web interface? A simple sentence like "This will be run every time promises are regenerated on the root server" will suffice.
|
Aside from wording, this looks great. Please fix wording (here and in the default rudder-web.properties from Normation/rudder#617) and merge. |
ncharles
force-pushed
the
ust_5571/int/5732_add_migration_script_for_command
branch
from
d3d4b9b
to
2cf3d3b
Compare
|
PR updated |
ncharles
added a commit
that referenced
this pull request
Nov 12, 2014
…_script_for_command Fixes #5732: Add migration script to add rudder.cfengine.reload.server.c...
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ommand