Fixes #6176: cannot use \"enabled\" json parameter in Directive API #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -573,7 +573,7 @@ case class RestExtractorService ( | |||
| name <- extractOneValueJson(json, "displayName")(convertToMinimalSizeString(3)) | |||
| shortDescription <- extractOneValueJson(json, "shortDescription")() | |||
| longDescription <- extractOneValueJson(json, "longDescription")() | |||
| enabled <- extractOneValueJson(json, "enabled")( convertToBoolean) | |||
| enabled <- extractJsonBoolean(json, "enabled") | |||
There was a problem hiding this comment.
doesn't it prevent it from using it outside the json ?
There was a problem hiding this comment.
json and 'params' are treated separetely (look line 547)
ncharles
added a commit
that referenced
this pull request
Jan 26, 2015
…d_json_parameter_in_directive_api Fixes #6176: cannot use \"enabled\" json parameter in Directive API
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.rudder-project.org/redmine/issues/6176