Fixes #7407: Display failed cf-promises to make it easier to re-run while debugging #959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -356,6 +356,7 @@ class Cf3PromisesFileWriterServiceImpl( | |||
| * and "error/technical details" | |||
| */ | |||
| val completeErrorMsg = ( s"The generated promises are invalid!errormessage!cf-promise check fails for promises generated at '${paths.newFolder}'" | |||
| + "<-Test command is: '" + checkCommand + "'" | |||
| + (if(errors.isEmpty) "" else errors.mkString("<-", "<-", "")) | |||
There was a problem hiding this comment.
This change should work because the "client side" cuts the message up using the "<-" separator, to replace it by a new line (<br/>).
|
This whole PR is just a proposal for a quick fix to display the command run. This may not be the best approach - as you know my Scala experience is rather limited. Any feedback welcome. |
| @@ -356,6 +356,7 @@ class Cf3PromisesFileWriterServiceImpl( | |||
| * and "error/technical details" | |||
| */ | |||
| val completeErrorMsg = ( s"The generated promises are invalid!errormessage!cf-promise check fails for promises generated at '${paths.newFolder}'" | |||
| + "<-Test command is: '" + checkCommand + "'" | |||
There was a problem hiding this comment.
I'm wondering if the message could be better with "promise check command is:"
What do you think @jooooooon ?
There was a problem hiding this comment.
I propose "Command to check generated promises is:"
|
Apart the question on the text, it's ok to me and can be merged (once we are ok about the text ;) ) |
|
PR updated |
jooooooon
force-pushed
the
ust_7407/display_failed_cf_promises_to_make_it_easier_to_re_run_while_debugging
branch
from
2391997
to
b2219f3
Compare
VinceMacBuche
added a commit
that referenced
this pull request
Nov 13, 2015
…mises_to_make_it_easier_to_re_run_while_debugging Fixes #7407: Display failed cf-promises to make it easier to re-run while debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7407