Fixes #3181 : Improve delete node feedback (Event log, node history) #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,8 +71,24 @@ class RemoveNodeServiceImpl( | |||
| case "root" => Failure("The root node cannot be deleted from the nodes list.") | |||
| case _ => { | |||
| for { | |||
| lastInventoryVersion <-inventoryHistoryLogRepository.versions(nodeId).map(_.head) | |||
There was a problem hiding this comment.
".head" method can fail. You will have to use "inventoryHistoryLogRepository.versions(nodeId).map( Box(_.headOption) ?~! "No version found for that node, it looks like an unconsistency in storage. Please try again to delete that node")
There was a problem hiding this comment.
After more thinking, why you don't simply use the "FullInventory.node.receiveDate" property to get the date of the last received inventory ?
fanf
added a commit
that referenced
this pull request
Jan 17, 2013
…as_Deleted Fixes #3181 : Improve delete node feedback (Event log, node history)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.rudder-project.org/redmine/issues/3181