Fix Windows file separator bug

[catalin-ursachi]

The following bit of code:

protected def traceFileName(dn:DN, opType:String) : String = {
    val fileName = dn.getRDNStrings().map( _.replaceAll(File.separator, "|")).reverse.mkString("/")
    fileName + "-" + System.currentTimeMillis.toString + "-" + opType + ".ldif"
  }

Appears to result in an error on Windows. Specifically, the problem is the following:

scala> "c\\programs\\ldap".replaceAll("\\", "x")
java.util.regex.PatternSyntaxException: Unexpected internal error near index 1
\
 ^
  at java.util.regex.Pattern.error(Pattern.java:1924)
  at java.util.regex.Pattern.compile(Pattern.java:1671)
  at java.util.regex.Pattern.<init>(Pattern.java:1337)
  at java.util.regex.Pattern.compile(Pattern.java:1022)
  at java.lang.String.replaceAll(String.java:2162)
  ... 33 elided

The first parameter of replaceAll is meant to be a Regex string. In Regex, a simple backslash must be double-escaped ("\\"); a simply-escaped backslash is a read as an escape character in Regex.

The following is a fix:

protected def traceFileName(dn:DN, opType:String) : String = {
    val fileName = dn.getRDNStrings().map( _.replaceAll("\\" + File.separator, "|")).reverse.mkString("/")
    fileName + "-" + System.currentTimeMillis.toString + "-" + opType + ".ldif"
  }

It works on Linux as well, as an escaped forward slash is simply a forward slash:

scala> "c/programs/ldap".replaceAll("\\/", "x")
res2: String = cxprogramsxldap

[fanf]

Wow, I'm totally sorry @catalin-ursachi, I completelly missed your PR! I opened ticket http://www.rudder-project.org/redmine/issues/7935 to track it on our side.

For the code itself, perhaps it could be neater to use Pattern.quote(File.separator), but thanks for pointing that out.

If you are still around after all that time, could you add in the commit message "Fixes #7935" so that the link with redmine is correctly done ?
And finally, if it's OK, could you target branches/rudder/2.11 in place of master, so that the fix happen in all our supported version (we have tools to up-merge easely).

Thanks again, and sorry again for the silence.

[fanf]

Superseeded by #15 which also target Rudder branch 2.11