Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected Japanese file. And accurate Japanese job's order. #76

Closed
Anko777 opened this issue Jul 13, 2023 · 9 comments · Fixed by dazemc/Parallels-Desktop-for-Mac-Business-Edition#10

Comments

@Anko777
Copy link

Anko777 commented Jul 13, 2023

Hi. Thanks for great works!

I corrected the important part of the Japanese file.
However, the mathematical part is esoteric and difficult to translate.
I will do my best to translate it.

ja.json file is here.
https://d.kuku.lu/276hneae3

and...

Can you change Japanese job's order?
I'm confused every time.
image

木工師 (Carpenter)
鍛冶師 (Blacksmith)
甲冑師 (Armorer)
彫金師 (Goldsmith)
革細工師 (Leatherworker)
裁縫師 (Weaver)
錬金術師 (Alchemist)
調理師 (Culinarian)
@Anko777 Anko777 changed the title Corrected Japanese file and accurate Japanese job's order. Corrected Japanese file. And accurate Japanese job's order. Jul 13, 2023
@dazemc
Copy link
Collaborator

dazemc commented Jul 13, 2023

Added the translation and I'll see what I can do about reordering later

@Anko777
Copy link
Author

Anko777 commented Jul 13, 2023

Thanks!

Oh, sorry.
I found bit mistake.

Please replace this.
https://d.kuku.lu/g8pcunzpx

@Anko777
Copy link
Author

Anko777 commented Jul 13, 2023

And I found a bug.

"Add crafter class icon to macro" option is not working on Japanese.
The Job's name must be Japanese to work.

Current
/micon Carpenter classjob

Correct
/micon 木工師 classjob

@dazemc
Copy link
Collaborator

dazemc commented Jul 13, 2023

I'll rewrite it to use the locale jsons later today

@dazemc
Copy link
Collaborator

dazemc commented Jul 14, 2023

Can you translate this string?

"Add crafter class icon to macro"

@Anko777
Copy link
Author

Anko777 commented Jul 14, 2023

Yes, I can.

マクロにクラスアイコンを追加する

@dazemc
Copy link
Collaborator

dazemc commented Jul 14, 2023

Can you review this before I push the commits?
I haven't reordered the classes yet.
https://dazemc.github.io/ffxiv-craft

@Anko777
Copy link
Author

Anko777 commented Jul 14, 2023

I checked.
OK, Perfect!

@dazemc
Copy link
Collaborator

dazemc commented Jul 14, 2023

I pushed the commits into this repo. Please let me know if there is any errors.

It's going to take me a few days to do the reordering because I do not know javascript, let alone angular, I'm just good at pretending. I need to write a function that checks the current translation and then chooses something like allClassesJA instead of the ordered list in allClasses. I can do all this except checking the current translation. This should be relatively easy to someone that knows the language. So, I will keep this open in the meantime. For anyone else that looks, the relative files are;

Dropdown menu (ng-repeat):
lines 26 - 33 in views/solver.html

Ordered Class list:
lines 4 - 13 in js/services/actions.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants