Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Symbol type to identify Instrument #8

Closed
Tracked by #9
Nouzan opened this issue Nov 29, 2022 · 1 comment
Closed
Tracked by #9

Add a Symbol type to identify Instrument #8

Nouzan opened this issue Nov 29, 2022 · 1 comment
Labels

Comments

@Nouzan
Copy link
Owner

Nouzan commented Nov 29, 2022

The current Hash implementation only hashes Instrument::symbol, which is good that we can use &str to query a Instrument in a hash map. But there are cases that different instruments sharing the same symbol, we should be able to support them.

@Nouzan Nouzan added the v0.2 label Nov 29, 2022
@Nouzan Nouzan mentioned this issue Nov 29, 2022
2 tasks
@Nouzan
Copy link
Owner Author

Nouzan commented Dec 2, 2022

Finished at 092f87b.

@Nouzan Nouzan closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant