Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

train reliability improvements #39

Closed
Novakasa opened this issue Nov 25, 2022 · 4 comments
Closed

train reliability improvements #39

Novakasa opened this issue Nov 25, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Novakasa
Copy link
Owner

Novakasa commented Nov 25, 2022

Instead of just sending the next expected marker and the behavior, send the full list of markers until the next block, with markers tagged if they have a role in the block, and also send the expected behaviour (stop in block / pass the block)

That way, if something changes (can't pass anymore) we just have to send the new behavior and the train itself knows whether it should have slowed down by now and correct for it.

All other solutions are unreliable since we don't know for sure if the train already passed a specific marker or not.

@Novakasa Novakasa added the enhancement New feature or request label Nov 25, 2022
@Novakasa Novakasa self-assigned this Nov 25, 2022
@Novakasa Novakasa changed the title make BLETrain know about blocks train reliability improvements Nov 25, 2022
@Novakasa
Copy link
Owner Author

also, anytime a train starts a route leg (locks some tracks) other trains should re-check immediately whether they can still pass their next block.

@Novakasa
Copy link
Owner Author

when the train passes, we could already send the instructions for the next leg, which should be buffered by the train (it still needs to finish the previous instructions).

@Novakasa
Copy link
Owner Author

we could simulate the reliability without real trains by adding a communication delay to VirtualTrain

@Novakasa
Copy link
Owner Author

this has been mostly implemented since f0a8b3d and previous commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant