Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let table scrollbar start at first row instead of header row #2446

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

TrimmingFool
Copy link
Contributor

@TrimmingFool TrimmingFool commented Jan 29, 2023

  • With paddingTop the table scrollbar intersects with table header row:
    before
  • With marginTop this is not the case and it is easier to tell when the top row is reached:
    after
  • Non-square label icons are stretched to fit 16x16 px

fix table scrollbar
@stickz
Copy link
Collaborator

stickz commented Jan 29, 2023

@TrimmingFool Could you post screenshots before and after? This will allow a fast merge of the pull request into master.

@stickz
Copy link
Collaborator

stickz commented Jan 29, 2023

Excellent thanks for the screenshots. Looks good to me and I can see this change was tested.

@stickz stickz merged commit 1bcdd30 into Novik:master Jan 29, 2023
@TrimmingFool TrimmingFool mentioned this pull request Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants