tree-view: Rewrite updateCustomLabels #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, the custom labels are explicitly processed as a tree. Empty label nodes which only have one child are flattened unless `webui.show_empty_path_labels` is `true`. Additionally, the children of `clabel_cont` and `lbll` now both reside in `plabel_cont` and are updated in `updateCustomLabels`, as well. Fixes Novik#2548 Novik#2549 Novik#2550
|
Thanks. I will test and distribute a hotfix. Might not get around to it until next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like, I forgot in 5fc2a7f to change
this.labels[el.id]?.sizehere:ruTorrent/js/webui.js
Line 2117 in 3251c5b
Since
updateCustomLabelshad the plain label listing as default, it made it hard to understand the tree logic.Now, the custom labels are explicitly processed as a tree. Empty label nodes which only have one child are flattened unless
webui.show_empty_path_labelsistrue.Additionally, the children of
clabel_contandlbllnow both reside inplabel_contand are updated in
updateCustomLabels, as well.Fixes #2548 #2549 #2550
