Convert bolt-replacements/getWorkspaces to TypeScript #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: 880c702 We got this. Not sure waht this means? Click here to learn what changesets are. |
🦋 Changeset is good to goLatest commit: 3c063b6 We got this. Not sure what this means? Click here to learn what changesets are. |
1 similar comment
🦋 Changeset is good to goLatest commit: 3c063b6 We got this. Not sure what this means? Click here to learn what changesets are. |
🦋 Changeset is good to goLatest commit: 3c063b6 We got this. Not sure waht this means? Click here to learn what changesets are. |
Noviny
approved these changes
May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts a single file to TypeScript which is the one that depends on
get-workspaces, I converted this specific file so that I could test type resolving across packages in a monorepo and what preconstruct needs to do. What I've ended up with is preconstruct creates a symlink fromdist/get-workspaces.cjs.js.tsto the source file in dev and in prod, it generates a file atdist/get-workspaces.cjs.js.d.tswhich is just like the flow redirect. (I want to generate actual TS declarations soon but this is a good first step)