Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio popping/crackling with version 1.13.1 #469

Closed
zenxero opened this issue May 18, 2022 · 17 comments
Closed

Audio popping/crackling with version 1.13.1 #469

zenxero opened this issue May 18, 2022 · 17 comments

Comments

@zenxero
Copy link

zenxero commented May 18, 2022

Hi, I noticed that there was some strange audio popping/crackling in the new 1.13.1 version that was not there in the previous version. This seems to happen with sound effects and is most noticeable with the axe "ting" effect and the nailgun firing sound.

As a test, I tried a fresh download and extraction of versions 1.13.0 and 1.13.1 with no external music loaded, no mods, only the PAK0 and PAK1 files under the id1 directory. All audio settings were left at defaults.

Here's a video demonstration with audio that has the crackling:

https://www.youtube.com/watch?v=oGWM9bWph2A

00:00 - Version 1.13.0 with no audio crackling
02:10 - Version 1.13.1 with audio crackling
04:20 - Lowering the game volume doesn't seem to make a difference

You can hear the direct difference most easily from the axe "tings" at timestamps 0:30 and 2:43.

@temx
Copy link
Collaborator

temx commented May 18, 2022

Do you still have this problem if you use 1.13.1's executable along with 1.13.0's SDL2.dll?

@zenxero
Copy link
Author

zenxero commented May 18, 2022

That fixed the issue! Replacing the SDL2.dll file with the older one from version 1.13.0 results in no audio popping.

@sezero
Copy link
Collaborator

sezero commented May 18, 2022

Do you think it's related to this SDL2-2.0.22 change?
libsdl-org/SDL@9e264b9
Reference issue: libsdl-org/SDL#5538 (also see libsdl-org/SDL#5540)

@zenxero
Copy link
Author

zenxero commented May 18, 2022

I tested this on my laptop as well and it exhibits the same behavior. My desktop has an AMD X570 series motherboard with a Realtek audio chip. However, I'm using a USB DAC audio interface instead of the regular audio jack. But the popping still happens over the USB interface as well.

Desktop audio:
Screenshot 2022-05-18 111729

My laptop is also an AMD-based system with a Realtek audio chip. I tested it with some basic earbuds plugged into the audio jack and it has the popping on version 1.13.1. But replacing the SDL2.dll file fixes it there as well.

Laptop audio:

Screenshot 2022-05-18 111627

@sezero
Copy link
Collaborator

sezero commented May 18, 2022

Can you also test whether SDL2-2.0.20 has the issue for you? I.e. the dll from
http://libsdl.org/release/SDL2-2.0.20-win32-x64.zip (or if it is 32 bits you are running
then http://libsdl.org/release/SDL2-2.0.20-win32-x86.zip)

@zenxero
Copy link
Author

zenxero commented May 18, 2022

That SDL file (I used the 64-bit one), paired with 1.13.1 sounds fine. No popping or crackling.

@sezero
Copy link
Collaborator

sezero commented May 18, 2022

So 2.0.22 has the issue -- possibly due to the change I mentioned above?

@zenxero
Copy link
Author

zenxero commented May 18, 2022

Seems plausible. Unfortunately, I'm no developer so I can't really comment on such things.

@Riccardoman
Copy link

I'm experiencing the same issue

@zenxero
Copy link
Author

zenxero commented May 18, 2022

@Riccardoman

Seems like the solution for the moment is to either use the SDL2.dll file that came with version 1.13.0, or download it from the link below and put it into the vkQuake directory.

http://libsdl.org/release/SDL2-2.0.20-win32-x64.zip

@Novum
Copy link
Owner

Novum commented May 25, 2022

@sezero Where are we with this? Should we revert to 2.0.21 in the meantime?

@sezero
Copy link
Collaborator

sezero commented May 25, 2022

@sezero Where are we with this? Should we revert to 2.0.21 in the meantime?

Waiting for @icculus' response for the time being.

@sezero
Copy link
Collaborator

sezero commented May 25, 2022

Can you reproduce the issue, btw?

@zenxero
Copy link
Author

zenxero commented May 25, 2022

Ok, so I tested the vkQuake 1.13.1 app image on the Steam Deck (Linux) and it does NOT have the audio crackling or popping issue that my Windows machines have.

@zenxero
Copy link
Author

zenxero commented May 25, 2022

Ah, well now I feel stupid. Turns out if I force my audio device to use 44100 Hz instead of 48000 Hz, the popping/crackling goes away. I'm sorry for the trouble, this seems to have solved the issue.

@Riccardoman Is your audio device set to use 48000 Hz in the Windows sound settings? If so, try setting it to 44100 Hz instead.

@icculus
Copy link

icculus commented May 25, 2022

So this is an SDL issue, and we're working on it, but this vkQuake bug can probably be closed.

@Novum
Copy link
Owner

Novum commented May 26, 2022

Thanks @icculus

@Novum Novum closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants