-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WASAPI: Set sample rate via IAudioClockAdjustment #5540
Conversation
This might reintroduce the quality issues fixed by b98b5ad and may cause resampling failures in other cases. I've not tested with both Previous discussions for context: Repro steps for Other comments mentioning limitations of |
We might have to revert to using SDL for resampling if this does not fix quality issues or if |
This does not fix the problem Can we go back to SDL's resampling? |
I don't mind changing back, but I'm extremely hesitant to do it right before 2.0.22 ships. I'm okay with it if @slouken gives the greenlight, otherwise we can flip this as soon as 2.0.22 ships. |
Yep, I flipped it back in 9e264b9 |
Thanks! |
You're welcome! |
Potential fix for #5538