Consolidation #1387
Merged
Consolidation #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2016
|
@janette Follows a list of extra cleanup steps that need to be done here:
|
+ Sets proper docroot path for boot.php + Sets circle to run phpunit tests
|
@janette, take a look at the PR above |
…ate_base Consolidation - Updates dkan migrate base
…8a2f4c5d7a, see dkan_dataset PR 141 & 148
dafeder
requested changes
Oct 13, 2016
| @@ -2,173 +2,387 @@ api: '2' | |||
| core: 7.x | |||
| includes: | |||
| - "https://raw.githubusercontent.com/NuCivic/dkan_dataset/7.x-1.x/dkan_dataset.make" | |||
There was a problem hiding this comment.
This should not be here anymore
| - "modules/dkan/dkan_data_story/dkan_data_story.make" | ||
| - "modules/dkan/dkan_topics/dkan_topics.make" | ||
| - "modules/dkan/dkan_harvest/dkan_harvest.make" | ||
| - "https://raw.githubusercontent.com/NuCivic/leaflet_draw_widget/860437c9e6813cf829fee91b31b0968a2f4c5d7a/leaflet_widget.make" |
There was a problem hiding this comment.
Point this to master for the 7.x-1.x branch, not a specific commit
dafeder
approved these changes
Oct 13, 2016
This was referenced Jul 12, 2017
dafeder
pushed a commit
that referenced
this pull request
Apr 24, 2020
dkan_dataset, dkan_datastore, dkan_migrate_base, dkan_workflow all moved into core * Move dkan_datastore into dkan core * Apply dkan_datastore pr #76 * Move unit tests to core * Move dkan_migrate_base repo into dkan core * Delete unnecessary files, clean up others * Remove probo, circle, dkan.make, init.sh, and duplicate test files * civic-2537 consolidate make files * Clean up dkan_datastore files, update changelog to incluce dkan_datastore info * Merge dkan_dataset into dkan core * Clean up changelog, disable fast_import tests * Updates to latest dkan_migrate_base * + Updates composer.lock so it installs phpunit + Sets proper docroot path for boot.php + Sets circle to run phpunit tests * Update drupal-org.make file * Update merge of dkan_dataset and integrate dkan_harvest make file * Revert changes to composer.lock file * Update leaflet_draw_widget to revision 860437c9e6813cf829fee91b31b0968a2f4c5d7a, see dkan_dataset PR 141 & 148 * Disable phpunit testing for now * Add wait steps so resource.editor tests pass * Update README.md * Create README.md for dkan_migrate_base grunt extender * Remove dkan_dataset make file and set leaflet_draw_widget to use master branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Description
one repo to rule them all
Additional work for alpha QA
phpunit tests
civic-4304
civic-4317