Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PackageDownload multiple versions doesn't work in Visual Studio. #11798

Closed
nkolev92 opened this issue May 6, 2022 · 2 comments · Fixed by NuGet/NuGet.Client#4613
Closed

PackageDownload multiple versions doesn't work in Visual Studio. #11798

nkolev92 opened this issue May 6, 2022 · 2 comments · Fixed by NuGet/NuGet.Client#4613
Assignees
@nkolev92
Labels
Category:Quality Week Issues that should be considered for quality week Partner:Roslyn Priority:2 Issues for the current backlog. Type:Bug
Milestone
6.3

Comments

@nkolev92
Copy link
Member

nkolev92 commented May 6, 2022

Originally changed in NuGet/NuGet.Client@ef9eb47, works on the commandline, but doesn't work in VS.

Bug here: https://github.com/NuGet/NuGet.Client/blob/f52a83999070237288d7e1c8ec5934a65eda77ac/src/NuGet.Clients/NuGet.SolutionRestoreManager/VSNominationUtilities.cs#L123

Example failure:

Severity Code Description Project File Line Suppression State
Error NU1105 Unable to read project information for 'EntityDesignBootstrapPackage': '[5.0.0];[6.2.0]' is not a valid version string. EntityDesignBootstrapPackage C:\dev\ef6tools\src\EFTools\EntityDesignBootstrapPackage\EntityDesignBootstrapPackage.csproj 1
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Type:Bug Partner:Roslyn Category:Quality Week Issues that should be considered for quality week labels May 6, 2022
@nkolev92 nkolev92 self-assigned this May 6, 2022
sharwell added a commit to sharwell/ef6tools that referenced this issue May 6, 2022
@sharwell
Split package download versions across projects
fbeff6d 
Currently Visual Studio reports NU1105 for multi-version PackageDownload
elements because it doesn't recognize [5.0.0];[6.2.0] as a valid version
number.

See NuGet/Home#11798
@nkolev92 nkolev92 mentioned this issue May 6, 2022
Merged
8 tasks
@vgriph
Copy link

vgriph commented May 24, 2022

Is the fix for this issue released in any Visual Studio version?

@heng-liu heng-liu added this to the 6.3 milestone May 25, 2022
@zivkan
Copy link
Member

zivkan commented May 26, 2022

Not yet. It will be in VS 17.3 preview 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nkolev92 nkolev92

Labels
Category:Quality Week Issues that should be considered for quality week Partner:Roslyn Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Milestone
6.3
Development

Successfully merging a pull request may close this issue.

Fix multiple version PackageDownload reading in VS NuGet/NuGet.Client
4 participants
@nkolev92 @vgriph @zivkan @heng-liu