New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve resolver failure messages #1373

Closed
emgarten opened this Issue Sep 10, 2015 · 3 comments

Comments

Projects
None yet
7 participants
@emgarten
Contributor

emgarten commented Sep 10, 2015

Resolver constraint error messages do not show enough information in some cases.

Steps

  1. Create a packages.config with an invalid combination of packages which violate the constraints
  2. Update a package that will bring in new dependencies but still fail

Expected:
If the original constraint problem is the core issue, that will be surfaced in the message

Actual:
NuGet favors messages around new dependencies since they are usually the problem, but in this case the existing packages are the problem and they are not listed in the error message.

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Mar 21, 2016

Contributor

This is only for packages.config, not xplat scenarios.

My current thinking is that this should be fixed by using a simple failure message from the optimistic resolver once that perf improvement goes in.

Contributor

emgarten commented Mar 21, 2016

This is only for packages.config, not xplat scenarios.

My current thinking is that this should be fixed by using a simple failure message from the optimistic resolver once that perf improvement goes in.

@rrelyea rrelyea added Area:VS.Client and removed CLI RC2 XPLAT labels Mar 29, 2016

@rrelyea rrelyea added this to the Client-VNext milestone Mar 29, 2016

@harikmenon harikmenon modified the milestones: Client-VNext, Future Apr 19, 2016

@emgarten emgarten assigned emgarten and jainaashish and unassigned joelverhagen and emgarten May 3, 2016

@rrelyea rrelyea modified the milestones: 3.4.5, Future Jun 3, 2016

@rrelyea rrelyea reopened this Jun 3, 2016

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea Jun 3, 2016

Contributor

Please port to 3.4.5.

Contributor

rrelyea commented Jun 3, 2016

Please port to 3.4.5.

jainaashish added a commit to NuGet/NuGet.Client that referenced this issue Jun 3, 2016

@jainaashish

This comment has been minimized.

Show comment
Hide comment
@jainaashish

jainaashish Jun 3, 2016

Contributor

Merged with 5c85723fb07d28a7a305d93869e23013d72a2bd0

Contributor

jainaashish commented Jun 3, 2016

Merged with 5c85723fb07d28a7a305d93869e23013d72a2bd0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment