New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project.json nuget restore causes recompilation when nothing changed #2817

Closed
wbradney opened this Issue May 19, 2016 · 19 comments

Comments

Projects
None yet
4 participants
@wbradney

wbradney commented May 19, 2016

I see the following the the build log:

Input file "project.lock.json" is newer than output file "obj\Release\MyAssembly.dll".
Using "Csc" task from assembly "C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Build.Tasks.CodeAnalysis.dll".

Nothing changed between builds. Why is the restore process touching the lock file even when the project.json file didn't change?

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea May 19, 2016

Contributor

@wbradney - which version of nuget.exe or nuget.tools.vsix are you using?

Contributor

rrelyea commented May 19, 2016

@wbradney - which version of nuget.exe or nuget.tools.vsix are you using?

@wbradney

This comment has been minimized.

Show comment
Hide comment
@wbradney

wbradney May 19, 2016

This was observed with a recent nightly build of the command line: v3.5.0.1240

wbradney commented May 19, 2016

This was observed with a recent nightly build of the command line: v3.5.0.1240

@rrelyea rrelyea added this to the 3.5 RC milestone May 19, 2016

@rrelyea rrelyea added the Type:Bug label May 19, 2016

@rrelyea

This comment has been minimized.

Show comment
Hide comment
@rrelyea

rrelyea May 19, 2016

Contributor

that build is a dev branch build from 5/3/2016.

Contributor

rrelyea commented May 19, 2016

that build is a dev branch build from 5/3/2016.

@wbradney

This comment has been minimized.

Show comment
Hide comment
@wbradney

wbradney May 20, 2016

Let me know if you need a simple repro solution and I can find time to create one.

wbradney commented May 20, 2016

Let me know if you need a simple repro solution and I can find time to create one.

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten May 20, 2016

Contributor

@wbradney a simple repro would be great 😄

Contributor

emgarten commented May 20, 2016

@wbradney a simple repro would be great 😄

@wbradney

This comment has been minimized.

Show comment
Hide comment
@wbradney

wbradney May 23, 2016

NugetRecompile.zip

Here you go. Just run msbuild build.proj several times from a dev command prompt and observe the build log.

wbradney commented May 23, 2016

NugetRecompile.zip

Here you go. Just run msbuild build.proj several times from a dev command prompt and observe the build log.

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jun 21, 2016

emgarten added a commit to NuGet/NuGet.Client that referenced this issue Jun 21, 2016

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Jun 21, 2016

Contributor

Thanks for the repro @wbradney I was able to track this down the cause, you can get a nightly build with the fix from: https://dist.nuget.org/index.html

Contributor

emgarten commented Jun 21, 2016

Thanks for the repro @wbradney I was able to track this down the cause, you can get a nightly build with the fix from: https://dist.nuget.org/index.html

@emgarten

This comment has been minimized.

Show comment
Hide comment
Contributor

emgarten commented Jun 21, 2016

@emgarten emgarten closed this Jun 21, 2016

@wbradney

This comment has been minimized.

Show comment
Hide comment
@wbradney

wbradney Jun 22, 2016

Thanks. The nightly seems old - is it building correctly?

wbradney commented Jun 22, 2016

Thanks. The nightly seems old - is it building correctly?

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Jun 22, 2016

Contributor

@wbradney looks like it is not updating on there, the build should be at least 1500.

Contributor

emgarten commented Jun 22, 2016

@wbradney looks like it is not updating on there, the build should be at least 1500.

@wbradney

This comment has been minimized.

Show comment
Hide comment
@wbradney

wbradney Jul 5, 2016

Sorry if I'm being dense, but where can I get the latest beta?

wbradney commented Jul 5, 2016

Sorry if I'm being dense, but where can I get the latest beta?

@harikmenon

This comment has been minimized.

Show comment
Hide comment
@harikmenon

This comment has been minimized.

Show comment
Hide comment
@harikmenon

harikmenon commented Jul 5, 2016

http://blog.nuget.org/20160502/Introducing-The-NuGet-Beta-Channel.html. if you want to subscribe to the our Beta Channel.

@wbradney

This comment has been minimized.

Show comment
Hide comment
@wbradney

wbradney Jul 5, 2016

OK thanks - I think that's the same as what appears here: https://dist.nuget.org/win-x86-commandline/v3.5.0-beta2/NuGet.exe
If so, that version doesn't appear to fix this issue.
The milestone on this issue is 3.6 beta, so I thought that maybe there was another nightly build I could grab.

wbradney commented Jul 5, 2016

OK thanks - I think that's the same as what appears here: https://dist.nuget.org/win-x86-commandline/v3.5.0-beta2/NuGet.exe
If so, that version doesn't appear to fix this issue.
The milestone on this issue is 3.6 beta, so I thought that maybe there was another nightly build I could grab.

@harikmenon

This comment has been minimized.

Show comment
Hide comment
@harikmenon

harikmenon Jul 5, 2016

our VSIX nightly builds are not exposed publically. @rrelyea any change we give a wayne a signed latest build to try out?

harikmenon commented Jul 5, 2016

our VSIX nightly builds are not exposed publically. @rrelyea any change we give a wayne a signed latest build to try out?

@wbradney

This comment has been minimized.

Show comment
Hide comment
@wbradney

wbradney Jul 5, 2016

It's not a big deal - I can build the client from source. We mostly test with the command-line client anyway.

wbradney commented Jul 5, 2016

It's not a big deal - I can build the client from source. We mostly test with the command-line client anyway.

@wbradney

This comment has been minimized.

Show comment
Hide comment
@wbradney

wbradney Jul 8, 2016

Rebuilt from a clean fetch and confirmed that this issue is fixed. Thanks!

wbradney commented Jul 8, 2016

Rebuilt from a clean fetch and confirmed that this issue is fixed. Thanks!

@wbradney

This comment has been minimized.

Show comment
Hide comment
@wbradney

wbradney Aug 9, 2016

Is this fix going to be available in a 3.5.x version?

wbradney commented Aug 9, 2016

Is this fix going to be available in a 3.5.x version?

@emgarten

This comment has been minimized.

Show comment
Hide comment
@emgarten

emgarten Aug 9, 2016

Contributor

@wbradney yes, this will be in 3.5.0-rc1. It looks like this was added to the wrong milestone, I'll fix it.

Contributor

emgarten commented Aug 9, 2016

@wbradney yes, this will be in 3.5.0-rc1. It looks like this was added to the wrong milestone, I'll fix it.

@emgarten emgarten modified the milestones: 3.5 RC, 3.6 Beta2 Aug 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment