Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project.json nuget restore causes recompilation when nothing changed #2817

Closed
wbradney opened this issue May 19, 2016 · 19 comments
Closed

project.json nuget restore causes recompilation when nothing changed #2817

wbradney opened this issue May 19, 2016 · 19 comments

Comments

@wbradney
Copy link

wbradney commented May 19, 2016

I see the following the the build log:

Input file "project.lock.json" is newer than output file "obj\Release\MyAssembly.dll".
Using "Csc" task from assembly "C:\Program Files (x86)\MSBuild\14.0\bin\Microsoft.Build.Tasks.CodeAnalysis.dll".

Nothing changed between builds. Why is the restore process touching the lock file even when the project.json file didn't change?

@rrelyea
Copy link
Contributor

rrelyea commented May 19, 2016

@wbradney - which version of nuget.exe or nuget.tools.vsix are you using?

@wbradney
Copy link
Author

This was observed with a recent nightly build of the command line: v3.5.0.1240

@rrelyea
Copy link
Contributor

rrelyea commented May 19, 2016

that build is a dev branch build from 5/3/2016.

@wbradney
Copy link
Author

Let me know if you need a simple repro solution and I can find time to create one.

@emgarten
Copy link
Member

@wbradney a simple repro would be great 😄

@wbradney
Copy link
Author

NugetRecompile.zip

Here you go. Just run msbuild build.proj several times from a dev command prompt and observe the build log.

@emgarten
Copy link
Member

Thanks for the repro @wbradney I was able to track this down the cause, you can get a nightly build with the fix from: https://dist.nuget.org/index.html

@emgarten
Copy link
Member

@wbradney
Copy link
Author

Thanks. The nightly seems old - is it building correctly?

@emgarten
Copy link
Member

@wbradney looks like it is not updating on there, the build should be at least 1500.

@wbradney
Copy link
Author

wbradney commented Jul 5, 2016

Sorry if I'm being dense, but where can I get the latest beta?

@harikmenon
Copy link

The latest 3.5 Beta 2 is available from https://dist.nuget.org/visualstudio-2015-vsix/v3.5.0-beta2/NuGet.Tools.vsix

@harikmenon
Copy link

http://blog.nuget.org/20160502/Introducing-The-NuGet-Beta-Channel.html. if you want to subscribe to the our Beta Channel.

@wbradney
Copy link
Author

wbradney commented Jul 5, 2016

OK thanks - I think that's the same as what appears here: https://dist.nuget.org/win-x86-commandline/v3.5.0-beta2/NuGet.exe
If so, that version doesn't appear to fix this issue.
The milestone on this issue is 3.6 beta, so I thought that maybe there was another nightly build I could grab.

@harikmenon
Copy link

our VSIX nightly builds are not exposed publically. @rrelyea any change we give a wayne a signed latest build to try out?

@wbradney
Copy link
Author

wbradney commented Jul 5, 2016

It's not a big deal - I can build the client from source. We mostly test with the command-line client anyway.

@wbradney
Copy link
Author

wbradney commented Jul 8, 2016

Rebuilt from a clean fetch and confirmed that this issue is fixed. Thanks!

@wbradney
Copy link
Author

wbradney commented Aug 9, 2016

Is this fix going to be available in a 3.5.x version?

@emgarten
Copy link
Member

emgarten commented Aug 9, 2016

@wbradney yes, this will be in 3.5.0-rc1. It looks like this was added to the wrong milestone, I'll fix it.

@emgarten emgarten modified the milestones: 3.5 RC, 3.6 Beta2 Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants