Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different project path casings can cause restore to lose PackageReferences #5855

Closed
emgarten opened this issue Sep 6, 2017 · 0 comments
Closed

Different project path casings can cause restore to lose PackageReferences #5855

emgarten opened this issue Sep 6, 2017 · 0 comments
Assignees
@emgarten
Labels
Functionality:Restore Style:PackageReference Type:Bug
Milestone
4.4

Comments

@emgarten
Copy link
Member

emgarten commented Sep 6, 2017

Different project path casings can cause restore to lose PackageReferences

Paths are treated as case sensitive to work cross platform, however MSBuild can return different casings for the same project file path when evaluating MSBuildThisFileFullPath. To workaround this restore should ignore casings on case-insensitive file systems.

Steps

  1. Create a project ab.csproj
  2. Create a solution referencing project AB.csproj
  3. Create another project referencing the project as aB.csproj
  4. Restore
@emgarten emgarten self-assigned this Sep 6, 2017
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Sep 6, 2017
@emgarten
Match project paths case insensitively for windows when creating the …
66f29a4 
…project spec

MSBuild can return different casings of the file path when evaluting the project at different times. To workaround this all paths should be compared case insensitively on case insensitive file systems.

Fixes NuGet/Home#5855
@emgarten emgarten mentioned this issue Sep 7, 2017
Merged
emgarten added a commit to NuGet/NuGet.Client that referenced this issue Sep 7, 2017
@emgarten
Match project paths case insensitively for windows when creating the …
8dbce8b 
…project spec

MSBuild can return different casings of the file path when evaluting the project at different times. To workaround this all paths should be compared case insensitively on case insensitive file systems.

Fixes NuGet/Home#5855
@emgarten emgarten added this to the 4.4 milestone Sep 7, 2017
@emgarten emgarten mentioned this issue Sep 12, 2017
Closed
@emgarten emgarten mentioned this issue Oct 19, 2017
Closed
@nkolev92 nkolev92 mentioned this issue Jan 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emgarten emgarten

Labels
Functionality:Restore Style:PackageReference Type:Bug
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
1 participant
@emgarten