Initial draft for adding a NUKE tab with installation instructions #10782
Conversation
|
|
||
| ## Prior Art | ||
|
|
||
| The Paket team successfully pioneered adding a new tab. The Cake team has successfully pushed [their proposal](https://github.com/NuGet/NuGetGallery/issues/8381). As I already mentioned in the issue, I'm not particularly fond of showing installation instructions for build-irrelevant packages. In any case, I'm limiting my proposal to packages with `DotnetTool` as a `packageType`. For everything else, i.e. `PackageReference`, the IDE capabilities should suffice. |
There was a problem hiding this comment.
Just to help clarify based on the proposal here:
In any case, I'm limiting my proposal to packages with DotnetTool as a packageType. For everything else, i.e. PackageReference, the IDE capabilities should suffice.
There was a visual proposal in the previous issue showing package dependencies. Can we assume that is cut from the scope in this proposal based on the above sentence regarding PackageReference?
There was a problem hiding this comment.
That's correct. Initially, I thought about joining based on the responses from @joelverhagen (and I appreciate the openness!), but I rather follow my own objections and limit the scope of this. There has been negative feedback about this already, so a second tab won't make it better :)
There was a problem hiding this comment.
@JonDouglas I need to add something. The packageType=DotnetTool is already available as metadata. Under Future Possibilities I also mentioned packages that have a ./tools folder. I don't know how likely it is to expect metadata about that at some point in the future, but it would be great if we could consider this part of the proposal. Let me know if I should clarify that! :)
|
Thank you so much for the contribution! We'll keep this proposal open for a couple weeks to collect community & NuGet contributor feedback. This is to ensure there's ample time for discussion prior to a quick team review. |
|
I don't have a lot to add, except that I'm loving NUKE and am very excited for this proposal to make using it even easier and more straightforward for the growing community😀 |
|
I echo @GeorgDangl's perspective. The value added through this proposal is something I fully support. Thanks to the Nuget team for being open to these types of proposals. |
|
Hey @matkoch I just wanted to let you know that given there's nothing but support for the proposal, we'll take a quick review now that's it's been a couple weeks and give you the 👍 to proceed with a PR shortly after a quick team review this afternoon. |
|
|
||
| ## Future Possibilities | ||
|
|
||
| I'm looking forward for the NuGet team to add more metadata to packages. This way we might also show the instructions for packages that have a `./tools` folder. |
There was a problem hiding this comment.
Please, create an issue for this metadata request in NuGet/Home
There was a problem hiding this comment.
Hey @matkoch
Thanks so much for the proposal. Feel free to work on a PR to implement on the NuGetGallery repo & we'll help review to merge!
Hi everyone!
I'm following up on @JonDouglas suggesting to use the new template for my original proposal from NuGet/NuGetGallery#8511.
Happy to answer your questions! :)