Support for PackageId in .NET Core project system #1200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve NuGet/Home#4586. Retrieve `PackageId` global un-evaluated property from the `ProjectRestoreInfo` on RPS nomination. Assign the value to `PackageSpec.Name` attribute. Use `ShortName` if the property is not defined (current behavior).
alpaix
requested review from
rohit21agrawal,
nkolev92,
emgarten,
mishra14 and
jainaashish
|
Working on adding end-to-end tests. Will post PR update later. |
natidea
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve NuGet/Home#4586.
Retrieve
PackageIdglobal un-evaluated property from theProjectRestoreInfoon RPS nomination. Assign the value toPackageSpec.Nameattribute. UseShortNameif the property is notdefined (current behavior).
//cc @rrelyea @DoRonMotter @natidea