Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

URLs in email confirmation email differ #2357

Closed
FransBouma opened this issue Feb 9, 2015 · 5 comments
Closed

URLs in email confirmation email differ #2357

FransBouma opened this issue Feb 9, 2015 · 5 comments
Assignees
@RanjiniM

Comments

@FransBouma
Copy link

Hi,

If you register at nuget.org, you need to confirm your email address. Nuget sends you an email for that. Now, I'm an old fart from the old days where you read your email using 'mail' on a shell prompt so I read all my emails in plain text. When I got the confirmation email, I saw this: (url changed to protect the innocent)

https://www.nuget.org/account/confirm/SomeName/uiRHuje67GrebnZIJMFA2 <https://www.nuget.org/account/confirm/SomeName/uiRHuj_e67Grebn_ZIJMFA2>

So I copied the first URL, and it failed with the message it's been expired. Puzzled, I clicked the resend confirmation email link. To my surprise I received a new email with the exact same URL. Of course it still failed. I thought I was going crazy (some might think I'd reached that point many years ago, but let's say I'm sane here), so I again requested an email, same url, same story. The reason I retried the URL was that I thought it might be a problem in the service.

After more than half an hour I realized there were two '_' in the second URL, the one inside the <> characters. Using that URL worked.

Now, for the love of everything that's holy, please, make both URLs the same. Not everyone reads their email in HTML format, some of us like it when the email text they're seeing is the actual email text, stripped from all hiding HTML mess that caused and still causes so much problems in the world.

Thank you.
@Niels-V
Copy link
Contributor

Niels-V commented Feb 9, 2015

Seems to be an issue with the Markdown mailer which uses the underscore as italic indicator. That means that either the MarkdownSharp property StrictBoldItalic should be set (which is not accessible from the MarkdownMailer), or the underscore need to be escaped.

Niels-V added a commit to Niels-V/NuGetGallery that referenced this issue Feb 9, 2015
@Niels-V
Escape underscores in confirmation urls for new accounts or changes e…
a2c2655 
…mail addresses NuGet#2357

Markdown sees the underscore as italics indicator, so underscores are
stripped in the message. This prevents cut and pasting of the address or
the use of text only email readers.
@Niels-V Niels-V mentioned this issue Feb 9, 2015
Merged
@ChrisSfanos
Copy link

Thanks for reporting this - at this time, this doesn't meet our bar.

@FransBouma
Copy link
Author

Wait, someone created a PR for you and you still refuse to fix it, even though the PR fixes it? Why? If it takes weeks to fix something, and you're nearing a deadline, sure, but the fix is right there!

@yishaigalatzer
Copy link

@FransBouma we missed the fact that you had a PR, reactivating.

@yishaigalatzer yishaigalatzer reopened this Apr 1, 2015
@RanjiniM
Copy link
Contributor

The PR has been merged into master now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RanjiniM RanjiniM

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yishaigalatzer @ChrisSfanos @RanjiniM @Niels-V @FransBouma