Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new warning NU3042 #3034

Merged
merged 3 commits into from
Apr 3, 2023
Merged

Document new warning NU3042 #3034

merged 3 commits into from
Apr 3, 2023

Conversation

dtivel
Copy link
Contributor

@dtivel dtivel commented Mar 23, 2023

Please do not merge yet. There are corresponding code changes that are still in review.

This change adds documentation for a new warning NU3042.

CC @JonDouglas, can you please review?

@dtivel dtivel requested review from a team as code owners March 23, 2023 00:01
@learn-build-service-prod

This comment was marked as resolved.

@learn-build-service-prod

This comment was marked as outdated.

@nkolev92
Copy link
Member

Where is NU3042 implemented?

It'll be great if all the warnings follow the prescribed methodology for warnings vs errors.
https://github.com/NuGet/NuGet.Client/blob/80c3c74ca5c6d67912a19833e8cc2b10f875dc95/src/NuGet.Core/NuGet.Common/Errors/NuGetLogCode.cs#LL21

I know a lot of the signing stuff doesn't, as lots of things are warnings in some cases, errors in others, but for true warnings we should consider it.

@dtivel
Copy link
Contributor Author

dtivel commented Mar 23, 2023

@nkolev92, NU3042 is implemented here.

From day 0, signing codes took a different approach with respect to warning vs. error, since the same NU code can be a warning or error depending on signature verification settings. Instead, the codes are just assigned monotonically from NU3000.

@learn-build-service-prod
Copy link

Learn Build status updates of commit a913ec8:

✅ Validation status: passed

File Status Preview URL Details
docs/reference/Errors-and-Warnings.md ✅Succeeded View
docs/reference/errors-and-warnings/NU3018.md ✅Succeeded View
docs/reference/errors-and-warnings/NU3028.md ✅Succeeded View
docs/reference/errors-and-warnings/NU3042.md ✅Succeeded View
docs/TOC.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@jeffkl jeffkl changed the title Add NU3042 Add NU3042 warning Mar 28, 2023
@jeffkl jeffkl changed the title Add NU3042 warning Document new warning NU3042 Mar 28, 2023
@dtivel dtivel merged commit 2068a63 into main Apr 3, 2023
@dtivel dtivel deleted the dtivel/NU3042 branch April 3, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants