Signing: log additional context when root is untrusted on Linux and macOS #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkolev92
reviewed
Mar 23, 2023
src/NuGet.Core/NuGet.Packaging/Signing/TrustStore/CertificateBundleX509ChainFactory.cs
Outdated
Show resolved
Hide resolved
kartheekp-ms
force-pushed
the
dev-dtivel-verification-on-linux
branch
from
d717fc0
to
c0e482c
Compare
|
@dtivel - I cloned the repo to review the changes locally but didn't intend to push a commit to your pull request. I clicked on sync or something by mistake in Visual Studio instead of fetch in Git Window. The commits list has only 1 commit which you have authored. Everything is good AFAIK. Sorry for the inconvenience. |
dtivel
force-pushed
the
dev-dtivel-verification-on-linux
branch
from
c0e482c
to
7c6440d
Compare
kartheekp-ms
previously approved these changes
Mar 24, 2023
|
@kartheekp-ms, can you please sign off again? I applied feedback from Nikolche, and that dismissed your approval. |
erdembayar
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#12459
Regression? Last working version: No
Description
This change improves the signed package verification user experience on Linux and macOS when verification fails because a root certificate is untrusted. This change raises a new warning (NU3042) to accompany an existing NU3018/NU3028 warning. The new warning provides actionable information on how to resolve these warnings.
TODO: create the aka.ms link
CC @JonDouglas, @aortiz-msft
PR Checklist
PR has a meaningful title
PR has a linked issue.
Described changes
Tests
Documentation