Fix CA1062 in NuKeeper.Inspection (#975)

NuKeeperDotNet · May 17, 2020 · 27d299e · 27d299e
1 parent 1595056
commit 27d299e
Show file tree

Hide file tree

Showing 16 changed files with 90 additions and 1 deletion.
diff --git a/NuKeeper.Inspection/Files/FolderFactory.cs b/NuKeeper.Inspection/Files/FolderFactory.cs
@@ -26,6 +26,11 @@ public FolderFactory(INuKeeperLogger logger)
         /// <returns></returns>
         public static IEnumerable<DirectoryInfo> GetTempDirsToCleanup(DirectoryInfo nukeeperTemp)
         {
+            if (nukeeperTemp == null)
+            {
+                throw new ArgumentNullException(nameof(nukeeperTemp));
+            }
+
             var dirs = nukeeperTemp.Exists ? nukeeperTemp.EnumerateDirectories() : Enumerable.Empty<DirectoryInfo>();
             var filterDatetime = DateTime.Now.AddHours(-1);
             return dirs.Where(d =>

diff --git a/NuKeeper.Inspection/Logging/LogData.cs b/NuKeeper.Inspection/Logging/LogData.cs
@@ -1,3 +1,4 @@
+using System;
 using NuKeeper.Abstractions.Logging;
 
 namespace NuKeeper.Inspection.Logging
@@ -12,6 +13,16 @@ public static class LoggerExtensions
     {
         public static void Log(this INuKeeperLogger logger, LogData data)
         {
+            if (data == null)
+            {
+                throw new ArgumentNullException(nameof(data));
+            }
+
+            if (logger == null)
+            {
+                throw new ArgumentNullException(nameof(logger));
+            }
+
             if (!string.IsNullOrWhiteSpace(data.Terse))
             {
                 logger.Minimal(data.Terse);

diff --git a/NuKeeper.Inspection/NuGetApi/ApiPackageLookup.cs b/NuKeeper.Inspection/NuGetApi/ApiPackageLookup.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Threading.Tasks;
 using NuGet.Packaging.Core;
 using NuKeeper.Abstractions;
@@ -22,6 +23,11 @@ public async Task<PackageLookupResult> FindVersionUpdate(
             VersionChange allowedChange,
             UsePrerelease usePrerelease)
         {
+            if (package == null)
+            {
+                throw new ArgumentNullException(nameof(package));
+            }
+
             var includePrerelease = ShouldAllowPrerelease(package, usePrerelease);
 
             var foundVersions = await _packageVersionsLookup.Lookup(package.Id, includePrerelease, sources);

diff --git a/NuKeeper.Inspection/NuGetApi/NuGetLogger.cs b/NuKeeper.Inspection/NuGetApi/NuGetLogger.cs
@@ -17,6 +17,11 @@ public NuGetLogger(INuKeeperLogger logger)
 
         public override void Log(ILogMessage message)
         {
+            if (message == null)
+            {
+                throw new ArgumentNullException(nameof(message));
+            }
+
             switch (message.Level)
             {
                 case LogLevel.Verbose:

diff --git a/NuKeeper.Inspection/NuGetApi/PackageLookupResultReporter.cs b/NuKeeper.Inspection/NuGetApi/PackageLookupResultReporter.cs
@@ -15,7 +15,7 @@ public PackageLookupResultReporter(INuKeeperLogger logger)
 
         public void Report(PackageLookupResult lookupResult)
         {
-            var highestVersion = lookupResult.Major?.Identity?.Version;
+            var highestVersion = lookupResult?.Major?.Identity?.Version;
             if (highestVersion == null)
             {
                 return;

diff --git a/NuKeeper.Inspection/NuGetApi/PackageVersionsLookup.cs b/NuKeeper.Inspection/NuGetApi/PackageVersionsLookup.cs
@@ -29,6 +29,11 @@ public async Task<IReadOnlyCollection<PackageSearchMetadata>> Lookup(
             string packageName, bool includePrerelease,
             NuGetSources sources)
         {
+            if (sources == null)
+            {
+                throw new ArgumentNullException(nameof(sources));
+            }
+
             var tasks = sources.Items.Select(s => RunFinderForSource(packageName, includePrerelease, s));
 
             var results = await Task.WhenAll(tasks);

diff --git a/NuKeeper.Inspection/PackagesFoundLogger.cs b/NuKeeper.Inspection/PackagesFoundLogger.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using NuKeeper.Abstractions.Formats;
@@ -10,6 +11,11 @@ public static class PackagesFoundLogger
     {
         public static LogData Log(IReadOnlyCollection<PackageInProject> packages)
         {
+            if (packages == null)
+            {
+                throw new ArgumentNullException(nameof(packages));
+            }
+
             var projectPathCount = packages
                 .Select(p => p.Path)
                 .Distinct()

diff --git a/NuKeeper.Inspection/Report/Formats/CsvReportFormat.cs b/NuKeeper.Inspection/Report/Formats/CsvReportFormat.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using NuGet.Versioning;
@@ -18,6 +19,11 @@ public CsvReportFormat(IReportWriter writer)
 
         public void Write(string name, IReadOnlyCollection<PackageUpdateSet> updates)
         {
+            if (updates == null)
+            {
+                throw new ArgumentNullException(nameof(updates));
+            }
+
             WriteHeading();
 
             foreach (var update in updates)

diff --git a/NuKeeper.Inspection/Report/Formats/Description.cs b/NuKeeper.Inspection/Report/Formats/Description.cs
@@ -9,6 +9,11 @@ public static class Description
     {
         public static string ForUpdateSet(PackageUpdateSet update)
         {
+            if (update == null)
+            {
+                throw new ArgumentNullException(nameof(update));
+            }
+
             var occurrences = update.CurrentPackages.Count;
             var versionsInUse = update.CurrentPackages
                 .Select(p => p.Version)

diff --git a/NuKeeper.Inspection/Report/Formats/MetricsReportFormat.cs b/NuKeeper.Inspection/Report/Formats/MetricsReportFormat.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using NuGet.Versioning;
@@ -17,6 +18,11 @@ public MetricsReportFormat(IReportWriter writer)
 
         public void Write(string name, IReadOnlyCollection<PackageUpdateSet> updates)
         {
+            if (updates == null)
+            {
+                throw new ArgumentNullException(nameof(updates));
+            }
+
             _writer.WriteLine($"Packages with updates: {updates.Count}");
             WriteMajorMinorPatchCount(updates);
             WriteProjectCount(updates);

diff --git a/NuKeeper.Inspection/Report/Formats/TextReportFormat.cs b/NuKeeper.Inspection/Report/Formats/TextReportFormat.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using NuKeeper.Abstractions.RepositoryInspection;
 
@@ -14,6 +15,11 @@ public TextReportFormat(IReportWriter writer)
 
         public void Write(string name, IReadOnlyCollection<PackageUpdateSet> updates)
         {
+            if (updates == null)
+            {
+                throw new ArgumentNullException(nameof(updates));
+            }
+
             _writer.WriteLine(MessageForCount(updates.Count));
 
             foreach (var update in updates)

diff --git a/NuKeeper.Inspection/Report/Reporter.cs b/NuKeeper.Inspection/Report/Reporter.cs
@@ -23,6 +23,11 @@ public void Report(
             string fileName,
             IReadOnlyCollection<PackageUpdateSet> updates)
         {
+            if (updates == null)
+            {
+                throw new ArgumentNullException(nameof(updates));
+            }
+
             var destinationDesc = destination == OutputDestination.File ?
                 $" File '{fileName}'" :
                 destination.ToString();

diff --git a/NuKeeper.Inspection/RepositoryInspection/PackageInProjectReader.cs b/NuKeeper.Inspection/RepositoryInspection/PackageInProjectReader.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using NuKeeper.Abstractions.Logging;
 using NuKeeper.Abstractions.NuGet;
@@ -19,6 +20,11 @@ public PackageInProject Read(
             PackagePath path,
             IEnumerable<string> projectReferences)
         {
+            if (path == null)
+            {
+                throw new ArgumentNullException(nameof(path));
+            }
+
             if (string.IsNullOrWhiteSpace(id))
             {
                 _logger.Normal($"Skipping package with no id specified in file '{path.FullName}'.");

diff --git a/NuKeeper.Inspection/Sort/TopologicalSort.cs b/NuKeeper.Inspection/Sort/TopologicalSort.cs
@@ -26,6 +26,11 @@ public TopologicalSort(INuKeeperLogger logger, Func<T, T, bool> match)
         public IEnumerable<T> Sort(
             IReadOnlyCollection<SortItemData<T>> inputMap)
         {
+            if (inputMap == null)
+            {
+                throw new ArgumentNullException(nameof(inputMap));
+            }
+
             var inputItems = inputMap
                 .Select(i => i.Item)
                 .ToList();

diff --git a/NuKeeper.Inspection/Sources/NuGetConfigFileReader.cs b/NuKeeper.Inspection/Sources/NuGetConfigFileReader.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using NuGet.Configuration;
@@ -18,6 +19,11 @@ public NuGetConfigFileReader(INuKeeperLogger logger)
 
         public NuGetSources ReadNugetSources(IFolder workingFolder)
         {
+            if (workingFolder == null)
+            {
+                throw new ArgumentNullException(nameof(workingFolder));
+            }
+
             var settings = Settings.LoadDefaultSettings(workingFolder.FullPath);
 
             foreach (var file in settings.GetConfigFilePaths())

diff --git a/NuKeeper.Inspection/UpdatesLogger.cs b/NuKeeper.Inspection/UpdatesLogger.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Text;
 using NuKeeper.Abstractions.RepositoryInspection;
@@ -9,6 +10,11 @@ public static class UpdatesLogger
     {
         public static LogData Log(IReadOnlyCollection<PackageUpdateSet> updates)
         {
+            if (updates == null)
+            {
+                throw new ArgumentNullException(nameof(updates));
+            }
+
             var headline = $"Found {updates.Count} possible updates";
             var details = new StringBuilder();