Fix CA1062 in NuKeeper.Update (#978)

NuKeeperDotNet · May 18, 2020 · 37b937d · 37b937d
1 parent 7a0b057
commit 37b937d
Show file tree

Hide file tree

Showing 9 changed files with 86 additions and 2 deletions.
diff --git a/NuKeeper.Update/Process/DotNetUpdatePackageCommand.cs b/NuKeeper.Update/Process/DotNetUpdatePackageCommand.cs
@@ -21,6 +21,21 @@ public DotNetUpdatePackageCommand(IExternalProcess externalProcess)
         public async Task Invoke(PackageInProject currentPackage,
             NuGetVersion newVersion, PackageSource packageSource, NuGetSources allSources)
         {
+            if (currentPackage == null)
+            {
+                throw new ArgumentNullException(nameof(currentPackage));
+            }
+
+            if (packageSource == null)
+            {
+                throw new ArgumentNullException(nameof(packageSource));
+            }
+
+            if (allSources == null)
+            {
+                throw new ArgumentNullException(nameof(allSources));
+            }
+
             var projectPath = currentPackage.Path.Info.DirectoryName;
             var projectFileName = currentPackage.Path.Info.Name;
             var sourceUrl = UriEscapedForArgument(packageSource.SourceUri);

diff --git a/NuKeeper.Update/Process/NuGetFileRestoreCommand.cs b/NuKeeper.Update/Process/NuGetFileRestoreCommand.cs
@@ -1,3 +1,4 @@
+using System;
 using System.IO;
 using System.Runtime.InteropServices;
 using System.Threading.Tasks;
@@ -31,6 +32,16 @@ public NuGetFileRestoreCommand(
 
         public async Task Invoke(FileInfo file, NuGetSources sources)
         {
+            if (file == null)
+            {
+                throw new ArgumentNullException(nameof(file));
+            }
+
+            if (sources == null)
+            {
+                throw new ArgumentNullException(nameof(sources));
+            }
+
             _logger.Normal($"Nuget restore on {file.DirectoryName} {file.Name}");
 
             var nuget = _nuGetPath.Executable;
@@ -83,6 +94,11 @@ public async Task Invoke(FileInfo file, NuGetSources sources)
         public async Task Invoke(PackageInProject currentPackage,
             NuGetVersion newVersion, PackageSource packageSource, NuGetSources allSources)
         {
+            if (currentPackage == null)
+            {
+                throw new ArgumentNullException(nameof(currentPackage));
+            }
+
             await Invoke(currentPackage.Path.Info, allSources);
         }
     }

diff --git a/NuKeeper.Update/Process/NuGetUpdatePackageCommand.cs b/NuKeeper.Update/Process/NuGetUpdatePackageCommand.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Runtime.InteropServices;
 using System.Threading.Tasks;
 using NuGet.Configuration;
@@ -31,6 +32,16 @@ public NuGetUpdatePackageCommand(
         public async Task Invoke(PackageInProject currentPackage,
             NuGetVersion newVersion, PackageSource packageSource, NuGetSources allSources)
         {
+            if (currentPackage == null)
+            {
+                throw new ArgumentNullException(nameof(currentPackage));
+            }
+
+            if (allSources == null)
+            {
+                throw new ArgumentNullException(nameof(allSources));
+            }
+
             var projectPath = currentPackage.Path.Info.DirectoryName;
 
             var nuget = _nuGetPath.Executable;

diff --git a/NuKeeper.Update/Process/SolutionsRestore.cs b/NuKeeper.Update/Process/SolutionsRestore.cs
@@ -1,3 +1,4 @@
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
@@ -18,6 +19,11 @@ public SolutionsRestore(IFileRestoreCommand fileRestoreCommand)
 
         public async Task CheckRestore(IEnumerable<PackageUpdateSet> targetUpdates, IFolder workingFolder, NuGetSources sources)
         {
+            if (workingFolder == null)
+            {
+                throw new ArgumentNullException(nameof(workingFolder));
+            }
+
             if (AnyProjectRequiresNuGetRestore(targetUpdates))
             {
                 await Restore(workingFolder, sources);

diff --git a/NuKeeper.Update/Process/UpdateDirectoryBuildTargetsCommand.cs b/NuKeeper.Update/Process/UpdateDirectoryBuildTargetsCommand.cs
@@ -23,6 +23,16 @@ public UpdateDirectoryBuildTargetsCommand(INuKeeperLogger logger)
         public Task Invoke(PackageInProject currentPackage, NuGetVersion newVersion, PackageSource packageSource,
             NuGetSources allSources)
         {
+            if (currentPackage == null)
+            {
+                throw new ArgumentNullException(nameof(currentPackage));
+            }
+
+            if (newVersion == null)
+            {
+                throw new ArgumentNullException(nameof(newVersion));
+            }
+
             XDocument xml;
             using (var xmlInput = File.OpenRead(currentPackage.Path.FullName))
             {

diff --git a/NuKeeper.Update/Process/UpdateNuspecCommand.cs b/NuKeeper.Update/Process/UpdateNuspecCommand.cs
@@ -1,3 +1,4 @@
+using System;
 using System.IO;
 using System.Linq;
 using System.Threading.Tasks;
@@ -7,7 +8,6 @@
 using NuKeeper.Abstractions.Logging;
 using NuKeeper.Abstractions.NuGet;
 using NuKeeper.Abstractions.RepositoryInspection;
-using NuKeeper.Inspection.RepositoryInspection;
 
 namespace NuKeeper.Update.Process
 {
@@ -23,6 +23,16 @@ public UpdateNuspecCommand(INuKeeperLogger logger)
         public Task Invoke(PackageInProject currentPackage,
             NuGetVersion newVersion, PackageSource packageSource, NuGetSources allSources)
         {
+            if (currentPackage == null)
+            {
+                throw new ArgumentNullException(nameof(currentPackage));
+            }
+
+            if (newVersion == null)
+            {
+                throw new ArgumentNullException(nameof(newVersion));
+            }
+
             XDocument xml;
             using (var xmlInput = File.OpenRead(currentPackage.Path.FullName))
             {

diff --git a/NuKeeper.Update/Process/UpdateProjectImportsCommand.cs b/NuKeeper.Update/Process/UpdateProjectImportsCommand.cs
@@ -17,6 +17,11 @@ public class UpdateProjectImportsCommand : IUpdateProjectImportsCommand
         public Task Invoke(PackageInProject currentPackage,
             NuGetVersion newVersion, PackageSource packageSource, NuGetSources allSources)
         {
+            if (currentPackage == null)
+            {
+                throw new ArgumentNullException(nameof(currentPackage));
+            }
+
             var projectsToUpdate = new Stack<string>();
             projectsToUpdate.Push(currentPackage.Path.FullName);
 

diff --git a/NuKeeper.Update/Selection/UpdateSelection.cs b/NuKeeper.Update/Selection/UpdateSelection.cs
@@ -23,7 +23,13 @@ public IReadOnlyCollection<PackageUpdateSet> Filter(
             IReadOnlyCollection<PackageUpdateSet> candidates,
             FilterSettings settings)
         {
-            _settings = settings;
+            _settings = settings ?? throw new ArgumentNullException(nameof(settings));
+
+            if (candidates == null)
+            {
+                throw new ArgumentNullException(nameof(candidates));
+            }
+
             if (settings.MinimumAge != TimeSpan.Zero)
             {
                 _maxPublishedDate = DateTime.UtcNow.Subtract(settings.MinimumAge);

diff --git a/NuKeeper.Update/UpdateRunner.cs b/NuKeeper.Update/UpdateRunner.cs
@@ -40,6 +40,11 @@ public UpdateRunner(
 
         public async Task Update(PackageUpdateSet updateSet, NuGetSources sources)
         {
+            if (updateSet == null)
+            {
+                throw new ArgumentNullException(nameof(updateSet));
+            }
+
             var sortedUpdates = Sort(updateSet.CurrentPackages);
 
             _logger.Detailed($"Updating '{updateSet.SelectedId}' to {updateSet.SelectedVersion} in {sortedUpdates.Count} projects");