Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Skipping package 'Microsoft.AspNetCore.App' with no version specified in file '....csproj'. #896

Closed
2 of 7 tasks
timmkrause opened this issue Nov 3, 2019 · 2 comments
Closed
2 of 7 tasks

Comments

@timmkrause
Copy link

timmkrause commented Nov 3, 2019

🐛 Bug Report

Having the following variant of a <PackageReference> where the version is mentioned in a sub-element:

    <PackageReference Include="Roslynator.Analyzers">
      <Version>2.2.0</Version>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>

NuKeeper outputs

Skipping package 'Roslynator.Analyzers' with no version specified in file 'D:\a\1\s\Directory.Build.props'.

Expected behavior

Sub-elements of a package reference containing the version should be taken into account as well.

Reproduction steps

Configuration

Version: 0.25.0

Platform if applicable:

  • 🛠️ NuKeeper CLI
  • ✨ GitHub
  • 🤖 AzureDevops
  • 🏁 Bitbucket
  • 🌎 Gitlab
  • 📺 Gitea
  • 🐳 Docker
@stale
Copy link

stale bot commented May 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 10, 2020
@timmkrause
Copy link
Author

Still having this issue, just seen it today with NuKeeper version 0.27.1:

Directory.Build.props:

<Project>
  <!-- Condition in place to circumvent NuGet restore error, see https://github.com/NuGet/Home/issues/8004. -->
  <ItemGroup Condition="'$(MSBuildProjectExtension)' != '.deployproj'">
    <PackageReference Include="Roslynator.Analyzers">
      <Version>2.3.0</Version>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>
    <PackageReference Include="StyleCop.Analyzers">
      <Version>1.1.118</Version>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>
    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers">
      <Version>2.9.8</Version>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>
  </ItemGroup>
</Project>

Log from NuKeeper run:

Skipping package 'Roslynator.Analyzers' with no version specified in file 'D:\a\1\s\Directory.Build.props'.
Skipping package 'StyleCop.Analyzers' with no version specified in file 'D:\a\1\s\Directory.Build.props'.
Skipping package 'Microsoft.CodeAnalysis.FxCopAnalyzers' with no version specified in file 'D:\a\1\s\Directory.Build.props'.

@stale stale bot removed the wontfix label May 13, 2020
skolima added a commit to skolima/NuKeeper that referenced this issue May 13, 2020
skolima added a commit to skolima/NuKeeper that referenced this issue May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant