Use targetBranch when running in a Azure DevOps Pipeline #1103
Conversation
|
In CreateSettingsFromRemote the targetBranch isn't used. Is this correct? |
|
Isn't this the same fix as #1078 ? |
|
Just ran into this issue, is there anyone still working on this? |
|
I'm not sure if NuKeeper is still alive. I have created my own version in my private repository with the needed changes. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…otNet#1113) * Add nuget restore CLI PackagesDirectory for package.config * Add required option when restoring via package.config * Add unit tests to ensure we include the CLI option * Fix unit tests to allow for multiple operating systems * Ensure that non windows OS's execute unit tests. * Fix repository filter unit tests * Remove tokens from source code (security) * Adjust OctokitClient to enable anonymous authentication if no token is supplied. * Add xml comments to the AuthSettings model * Help Nukeeper engineering's identify potentially duplicated code. * Assist with security token refactoring. * Fix the Nuget Restore tests * Ensure that unit tests have mono.CanRun set to true.
|
@MartinDemberger can you please rebase the branch on the latest master. Ty! |
Fix yaml code blocks
…tNet#1107) Co-authored-by: Ari Kalish <akalish@emoneyadvisor.com>
… of everyone in the Project (NuKeeperDotNet#1108) Co-authored-by: Ari Kalish <akalish@emoneyadvisor.com>
* 📦 Automatic update of NuGet.CommandLine to 5.11.0 * Bump packaging script to match nuget.commandline version
@msallin @i did the rebase but am unsure if it's done correct. There are changes in the changeset which I don't know. You can give me a short hint if I have done an error. Then I will redo the changes on a clean branch. |
|
@MartinDemberger I'm afraid something went wrong with the rebase - your changes were quite clean 3-4 lines, and this has about 30 extra commits. Could you re-do this so that the PR diff only shows your changes? |
|
I have recreated this PR as #1139 1139 |
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Fixes Bug #1102
Currently the targetBranch parameter isn't used when running in a Azure DevOps Pipeline.
🆕 What is the new behavior (if this is a feature change)?
Now the parameter is used.
💥 Does this PR introduce a breaking change?
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting