Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Add Yml file #581

Merged
merged 5 commits into from
Dec 5, 2018
Merged

Add Yml file #581

merged 5 commits into from
Dec 5, 2018

Conversation

shep1987
Copy link
Member

@shep1987 shep1987 commented Dec 3, 2018

Add the build config for Azure DevOps as a yml file. Meaning build config can be version controlled and reviewed before changes.

@MarcBruins
Copy link
Member

Why do we do a publish here?

@shep1987
Copy link
Member Author

shep1987 commented Dec 4, 2018

Why do we do a publish here?

image
This is the same as we do in the current release. Instead of having 2 configs one for PR and one for Master this just allows us to only publish if the branch being built is master (Via a manual trigger)

@MarcBruins
Copy link
Member

I've intentionally seperated the pipelines. Each branch should have its own responsibilities and pipeline. Pr should only concerns itself with the quality of the code that gets merged in. And the master build will contain preparation and a handle (drop) to the release pipeline. For now the master pipeline is small but it will get bigger when we use auto updates of the ado extension, docker image update etc

@AnthonySteele
Copy link
Member

AnthonySteele commented Dec 5, 2018

it's really nice to to have the pipeline config as a file under source control.
There is also benefit of having 2 different flows for branch build and test, and for a build, test and release from master.
But this can be done with a conditional step?

@MarcBruins
Copy link
Member

MarcBruins commented Dec 5, 2018

Alright, I'm open for this approach

@MarcBruins
Copy link
Member

:shipit:

@MarcBruins MarcBruins merged commit bc69993 into NuKeeperDotNet:master Dec 5, 2018
@shep1987 shep1987 deleted the AzureDevopsYml branch June 25, 2019 20:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants