Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

use dotnet format #685

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Conversation

AnthonySteele
Copy link
Member

@AnthonySteele
Copy link
Member Author

AnthonySteele commented Mar 5, 2019

It picked up a lot of minor spacing issues and inconsistencies, and I don't yet see anything that's worse.
If you were to run it regularly, the diffs would be much smaller.

Looks good to me!

@skolima
Copy link
Collaborator

skolima commented Mar 5, 2019

Personally I've used StyleCopAnalyzers + settings to the same effect. Is it possible to plug in this tool into the build, so that it formats by default?

Side note, but related: the files without \n before EOF suggest the .editorconfig for NuKeeper is incomplete. I could tailor the one I use to fit the style in NuKeeper, if you're interested?

@AnthonySteele
Copy link
Member Author

AnthonySteele commented Mar 5, 2019

I'm not familiar with getting StyleCopAnalyzers set up, I might take a look at it some time soon.
In the meantime, PRs are gladly accepted to enable StyleCop or to extend the .editorconfig here.

dotnet format is a good tool, I had successes running it today, so will use it again in some form, hopefully continuously or in smaller increments than this large PR!

@AnthonySteele AnthonySteele merged commit 4af6dbd into NuKeeperDotNet:master Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants