This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
#798 Respect Platform argument #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Hey @msallin, As this is a draft still did you need some help with this? Looks to me like this is close would be great to add a test to make sure you have fixed the issue! Thanks Shaun |
|
Due to an infrastructur issue I was not able to test until now. |
|
No worries, we all get busy! thank you for your time. There unfortunately seems to be merge conflicts now are you ok fixing these or did you need some help? |
|
Here we go. |
|
@shep1987 is there something I need to do, to get this PR merged? |
|
Sorry was at sisters wedding and then have just completed on a house so busy few weeks this all looks good thanks for the work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix.
Platform argument is not respected.
🆕 What is the new behavior (if this is a feature change)?
Platform argument is respected.
💥 Does this PR introduce a breaking change?
Maybe. If someone passes a platform argument, which is not respected and the platform argument does not correspond to the platform which is currently inferred from the URI, this change will be breaking.
🐛 Recommendations for testing
I tested only with BitbucketLocal and did no regressions tests.
📝 Links to relevant issues/docs
#798
🤔 Checklist before submitting