fix: moved hover and signatureHelp to signature.lua from lsp.lua

[yoplat]

Moved hover and signature help setup from lsp.lua to signature.lua to fix problem with noice

[yoplat]

@siduck This didn't fix anything, by putting it outside the setup function there is no check for the chadrc signature option, so it will always get executed no matter what. That's why I had put it inside there.

[siduck]

@carlobonandriniunimi check now

[yoplat]

@carlobonandriniunimi check now

Doesn't work neither. I tried using a fresh install of nvchad (with the example_config provided in the install) and it STILL complains. Only solution is what I had done. I doesn't seem to be an issue with my lspconfig, maybe NvChad, maybe Noice, maybe my Noice config but I don't think so.

[lucario387]

Because this essentially still replaces noice's handlers with nvchad's

[yoplat]

Because this essentially still replaces noice's handlers with nvchad's

That's what I was saying! It should be an option like with signature in the chadrc, it shouldn't even be that bad to do, just an if that surrounds those two commands

[siduck]

Because this essentially still replaces noice's handlers with nvchad's

That's what I was saying! It should be an option like with signature in the chadrc, it shouldn't even be that bad to do, just an if that surrounds those two commands

there is an option in chadrc, disable that

[lucario387]

There isn't it seems

[siduck]

@lucario387 https://github.com/NvChad/NvChad/blob/v3.0/lua/plugins/configs/lspconfig.lua#L18

[lucario387]

so why is it locked behind v3.0 and not at least backported to v2.0?

[yoplat]

@lucario387 https://github.com/NvChad/NvChad/blob/v3.0/lua/plugins/configs/lspconfig.lua#L18

DOES NOT WORK STILL. Even with example config from fresh install WITH lsp.signature.disabled = true.

[siduck]

@lucario387 https://github.com/NvChad/NvChad/blob/v3.0/lua/plugins/configs/lspconfig.lua#L18

DOES NOT WORK STILL. Even with example config from fresh install WITH lsp.signature.disabled = true.

wait for some minutes, i'm rewriting signature.lua

[yoplat]

@lucario387 https://github.com/NvChad/NvChad/blob/v3.0/lua/plugins/configs/lspconfig.lua#L18

DOES NOT WORK STILL. Even with example config from fresh install WITH lsp.signature.disabled = true.

wait for some minutes, i'm rewriting signature.lua

Also, in lspconfig.lua you are checking conf.signature:

if conf.signature and client.server_capabilities.signatureHelpProvider then
   require("nvchad.signature").setup(client)
end

But from the default_config (lsp.signature.disabled) it should be:

if not conf.signature.disabled and client.server_capabilities.signatureHelpProvider then
   require("nvchad.signature").setup(client)
end

So you need to change the defualt_config or how you are checking that to be enabled

[siduck]

@carlobonandriniunimi check now

[yoplat]

@carlobonandriniunimi check now

FIXED IT! Thanks! I think the biggest problem that I was having is that I was still using lsp.signature.disabled = false insted of lsp.signature = false.

[siduck]

@carlobonandriniunimi check now

FIXED IT! Thanks! I think the biggest problem that I was having is that I was still using lsp.signature.disabled = false insted of lsp.signature = false.

yea ik, although this problem led me into having a clean re-write of the signature module! 38782b6 😬