properly disable lsp signature

NvChad/ui#188 (comment)
roy-ren · Jan 4, 2024 · ec2c322 · ec2c322
1 parent d7d4da0
commit ec2c322
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lua/core/default_config.lua b/lua/core/default_config.lua
@@ -13,7 +13,6 @@ M.ui = {
   theme_toggle = { "onedark", "one_light" },
   theme = "onedark", -- default theme
   transparency = false,
-  lsp_semantic_tokens = false, -- needs nvim v0.9, just adds highlight groups for lsp semantic tokens
 
   -- https://github.com/NvChad/base46/tree/v2.0/lua/base46/extended_integrations
   extended_integrations = {}, -- these aren't compiled by default, ex: "alpha", "notify"
@@ -79,6 +78,8 @@ M.ui = {
       disabled = false,
       silent = true, -- silences 'no signature help available' message
     },
+
+    semantic_tokens = false,
   },
 
   term = {

diff --git a/lua/plugins/configs/lspconfig.lua b/lua/plugins/configs/lspconfig.lua
@@ -12,11 +12,15 @@ M.on_attach = function(client, bufnr)
 
   utils.load_mappings("lspconfig", { buffer = bufnr })
 
-  if client.server_capabilities.signatureHelpProvider then
+  -- signature stuff
+  local conf = utils.load_config().ui.lsp
+
+  if conf.signature and client.server_capabilities.signatureHelpProvider then
     require("nvchad.signature").setup(client)
   end
 
-  if not utils.load_config().ui.lsp_semantic_tokens and client.supports_method "textDocument/semanticTokens" then
+  -- semanticTokens
+  if not conf.semantic_tokens and client.supports_method "textDocument/semanticTokens" then
     client.server_capabilities.semanticTokensProvider = nil
   end
 end