Merge HTTPlug (PHP-HTTP) factories into single class #62
Conversation
|
Hm. Moving them to one factory makes sense. I agree. However, that will mess up php-http/discovery. They rely on these classes. We could update the discovery strategy. That would work if we assume everyone updates their dependencies. What do you think? Is it worth changing these classes? |
|
Rebased this now that #60 was merged.
On the one hand I would love for the 1.0.0 release to have a minimal amount of files and think it is weird that we can’t do that because of a completely unrelated package (minus your involvement in HTTPlug in general). On the other hand, if HTTPlug is going to pull the rug from php-http/message-factory anyway, maybe we should cut our losses and look forward to a 2.0.0 release completely without these classes instead? |
src/Factory/PhpHttpFactory.php
Outdated
| * @author Tobias Nyholm <tobias.nyholm@gmail.com> | ||
| * @author Martijn van der Ven <martijn@vanderven.se> | ||
| */ | ||
| final class PhpHttpFactory implements \Http\Message\MessageFactory, \Http\Message\StreamFactory, \Http\Message\UriFactory |
|
Blocked by #64, |
|
Squashed and rebased on new master. Waiting for checks to complete. Anything else blocking this? |
Basically more streamlining. This addresses my own confusion with the existence of separate factory files, as mentioned in #55 (comment).
Based on #60 and should be merged after.
With this change I also noticed we are calling our own factories within methods of the PSR-7 classes… why?