Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][IMP][crm] Add hook for preparing scheduled phonecall values and allow inheritance #482

Closed
wants to merge 2 commits into from

Conversation

antespi
Copy link

@antespi antespi commented Apr 22, 2016

This PR does not change Odoo behavior but adds a hook in order to inheritance it in other addons

Odoo PR odoo#11791

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 60.9% when pulling 1133688 on Antiun:imp-hook_schedule_phonecall into f5c5700 on OCA:8.0.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 60.9% when pulling 1133688 on Antiun:imp-hook_schedule_phonecall into f5c5700 on OCA:8.0.

@StefanRijnhart
Copy link
Member

This breaks compatibility in the following way: if a developer creates an extension and uses a hook, s/he should be able to rely on that this hook is in Odoo as well. Otherwise, s/he unknowingly creates an extension that is not compatible with Odoo, only with OCB.

A possible solution for the OCA domain was proposed here: https://odoo-community.org/groups/contributors-15/oca-contributors-25590

👎

@StefanRijnhart StefanRijnhart added this to the 8.0 milestone Jul 18, 2016
@antespi
Copy link
Author

antespi commented Feb 21, 2020

Long long time ago!

@antespi antespi closed this Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants