-
-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Exception when scheduling a phonecall from another #89
Conversation
res = super(CRMPhonecall, self)._prepare_another_phonecall_vals( | ||
call, schedule_time, call_summary, user_id=user_id, | ||
section_id=section_id, categ_id=categ_id) | ||
summary_id = (self.env.context and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should do res['summary_id'] = self.env.context.get('summary_id', res.get('summary_id', False))
.
Until OCA/OCB#482 or odoo/odoo#11791 merged, travis and runbot will be red |
This can't be merged on OCB, so the only chance is Odoo. |
Well, I hope Odoo HQ takes my PR into account. If not, we can see another approach to solve this bug. |
Can you add a test for the new behavior? |
Odoo is ignoring us and OCB fix is not an option, so I have to change strategy. Then when I have a new PR for this (without no core changes) I'll add test for it. |
Hi @antespi @pedrobaeza , none of the dependencies of this PR are going to be merged. So Please I think it's better to close this. Anyway we are migrating this problem to v9, so better we must find a way in v9. |
I'm closing this because requirements are not going to be merged. |
This PR fix a bug when scheduling a phonecall from another. Steps to reproduce:
An IntegrityError is raised:
This PR adds summary_id field to
crm.phonecall2phonecall
model and view in order to create a new call with that field assigned and avoid integrity error.This PR depends on these ones: