Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: check why loan provoques a fail. #1597

Merged
merged 2 commits into from
Mar 2, 2023
Merged

TEST: check why loan provoques a fail. #1597

merged 2 commits into from
Mar 2, 2023

Conversation

etobella
Copy link
Member

@etobella etobella commented Mar 1, 2023

No description provided.

@etobella etobella force-pushed the 14.0 branch 3 times, most recently from fdacc69 to 3d789fe Compare March 1, 2023 11:43
@etobella
Copy link
Member Author

etobella commented Mar 1, 2023

@rafaelbn @francesco-ooops Accomplished, but tests are failing due to some incompatibilites that have nothing to do with my changes :sad:

As you can see, the excluded tests are not working properly, as all modules are installed on the includes 😭

@etobella
Copy link
Member Author

etobella commented Mar 1, 2023

@sbidoul Any idea why github actions is not using the include / exclude logic?

May it come from here? OCA/oca-ci#44
Maybe we can fix it by this: https://github.com/sbidoul/manifestoo/blob/main/src/manifestoo/main.py#L198-L201 for

    if select_include:
        main_options.addons_selection.add_addon_names(select_include)
    elif select_addons_dirs:
        main_options.addons_selection.add_addons_dirs(select_addons_dirs)

@etobella
Copy link
Member Author

etobella commented Mar 2, 2023

Done! I will proceed with merge, as it is currently making the branch fail on runboat

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-1597-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e3670d9 into OCA:14.0 Mar 2, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 27fb879. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[14.0] account_loan module can not be installed
2 participants