Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] not use addon-dir when include is defined #45

Merged
merged 1 commit into from
Mar 1, 2023
Merged

[FIX] not use addon-dir when include is defined #45

merged 1 commit into from
Mar 1, 2023

Conversation

etobella
Copy link
Member

@etobella etobella commented Mar 1, 2023

@etobella
Copy link
Member Author

etobella commented Mar 1, 2023

@sbidoul might this be an option to fix the commented issue?

@sbidoul
Copy link
Member

sbidoul commented Mar 1, 2023

Yes, definitely, of course, thanks for the investigation. We may want to restore the addons script that was there before to factor out that logic.

@etobella
Copy link
Member Author

etobella commented Mar 1, 2023

Well, I think that my change might fix the issue 😁

@sbidoul
Copy link
Member

sbidoul commented Mar 1, 2023

Allrighty. Thanks!

@sbidoul sbidoul merged commit 55b5d64 into OCA:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etobella @sbidoul