8.0 ref port account product fiscal classification #28

legalsylvain · 2015-09-08T16:26:51Z

This PR :

is a merge of :
- OCA/account-fiscal-rule/account_product_fiscal_classification V7.0 ; (using the same name for module, models and fields)
- GRAP/odoo-addons-misc/account_taxes_group V7.0 ; (using the design of this module);
has been ported in V8, using new API;
includes remarks realized :
- by @rvalyi, @charbeljc, @jgrandguillaume, @sebastienbeau on [ADD] new module 'product_taxes_group' account-financial-tools#32;
- by @danimaribeiro, @sebastienbeau on previous PR : [ADD] product taxes group that replace account_product_fiscal_classification #24 ;
other topics :
- previous attempt at porting this module by @renatonlima : Feature/account product fiscal classification migration 8.0 #9

@danimaribeiro : sorry but I dropped your brazilian translation because all fields and model have changed.

danimaribeiro · 2015-09-08T16:59:40Z

account_product_fiscal_classification/README.rst

+  all the taxes;
+
+.. image:: ./static/src/img/product_template_accounting_setting.png
+


These images are not loading correctly. The names and path are wrong.

legalsylvain · 2015-09-08T17:39:58Z

@danimaribeiro : about that comment, #24 (comment) i didn't create a new description field, because the new name has big size. (256), the old one was 32 and the old description was 64.
I don't see the interest of this field. Are you agree with this removal, or do you see any issue ?

legalsylvain · 2015-09-08T17:44:23Z

account_product_fiscal_classification/model/account_product_fiscal_classification.py

+    product_tmpl_qty = fields.Integer(
+        string='Products Quantity', compute='_compute_product_tmpl_info')
+
+    purchase_tax_ids = fields.Many2many(


FYI : about #24 (comment)
I set purchase_tax_ids instead of purchase_base_tax_ids, for clarity. I used oldname and I set the same table name, so upgrade should work.
If your custom modules overload this field and sale_base_tax_ids, please make the changes.

legalsylvain · 2015-09-08T17:48:02Z

@ ALL : about the migration between a database V7 using account_product_fiscal_classification (with properties) and a V8 DB using this account_product_fiscal_classification module, I suggest you to simply uninstall the module before the migration. The installation of the module in V8 will create again all fiscal classification depending of all your product template configuration and set them to the according templates.

danimaribeiro · 2015-09-08T18:07:39Z

account_product_fiscal_classification/model/product_template.py

+            doc = etree.XML(res['arch'])
+            nodes = doc.xpath("//field[@name='fiscal_classification_id']")
+            if nodes:
+                nodes[0].set('required', '1')


I just didn't understand why you have to override fields_view_get just to set required.
Why not put to xml view directly?

Hi @danimaribeiro,
Indeed, my explication was not clear. I updated it. Please let me know if you have any doubt.
https://github.com/OCA/account-fiscal-rule/pull/28/files#diff-95ba4f4a046cd577c87a220edad46e0dR59

Ok thanks.
About the description there is no problem if you don't create, we inherit and add to it.
We use the name for the code, and description to description of classification, maybe we create the code instead of descritption.
For me it's ok now, I also asked @mileo to test this.

danimaribeiro · 2015-09-08T18:10:46Z

I did a full test in all functionalities.
Working perfectly 👍

rvalyi · 2015-09-08T21:01:10Z

hey thanks @legalsylvain I was about to ping you about that one again. Seems you need some nice work, I'll review that in detail tomorrow.

legalsylvain · 2015-09-09T17:12:51Z

@danimaribeiro or @mileo : could you pull translation again (BR) ?
If not, not a problem it could be done in another PR.
Kind regards.

danimaribeiro · 2015-09-09T17:14:55Z

I do the translations.

mileo · 2015-09-10T04:58:04Z

account_product_fiscal_classification/model/product_template.py

+                }
+            super(ProductTemplate, self.sudo()).write(tax_vals)
+        elif 'supplier_taxes_id' in vals.keys() or 'taxes_id' in vals.keys():
+            # product template Single update mode


I can't see how this branch of code will be used if the by normal user if in view this fields are readonly

all cases : While importing data. (see description of the module);
https://github.com/OCA/account-fiscal-rule/pull/28/files#diff-39aa8614d5d8e95ba38834e7370a8b07R34

custom cases : if a custom module set taxes not readonly; (to all user or some specific like accountant users)

mileo · 2015-09-10T05:00:28Z

Tested, nice work, we can do nice features in l10n-brazil with your work.

LGTM, just #28 (comment)

I can help in translations too.

legalsylvain · 2015-09-10T12:19:39Z

@danimaribeiro, @mileo : pot file added. I set also a field as translate = true.

renatonlima · 2015-09-10T12:51:06Z

I guys,

Maybe we can use transfix to manage translation for this repo? OCA/maintainer-quality-tools#194

I'll review that in detail...

thanks @legalsylvain

danimaribeiro · 2015-09-10T13:23:27Z

@legalsylvain I sent you a PR with translations.
grap#3
Could you at least copy the pt_BR.po file.

@renatonlima The translations in transifex work just after merge.

legalsylvain · 2015-09-10T13:35:59Z

Thanks. Merged.
kind regards.

legalsylvain · 2015-09-15T19:50:11Z

@rvalyi , @renatonlima : any news ?
kind regards.

renatonlima · 2015-09-18T20:37:36Z

Hi @legalsylvain,

Sorry for delay, LGTM!

Some remarks:

Here in Brazil our fiscal classifications has code and description, I think others fical classification uses too, like https://en.wikipedia.org/wiki/Harmonized_System;
Harmonized System has a hierarchy in our old module we have the field parent_id;
Template class, here in brazil we have around 14k fiscal classification records, we use one template to define sale and purchase taxes and use account.tax.template references from account chart to create records in account.fiscal.classification records.

I think we can aprove this PR and create others PR to implement these remarks

Good work!

kind regards.

legalsylvain · 2015-09-21T10:00:43Z

@renatonlima : Thanks for your review.
point 1 : done ;
point 2 and 3 : Yes, better to implement this kind of extra-feature in another PR ;

@ALL : this PR can be merged. (3 approvals)

rvalyi · 2015-09-22T16:16:22Z

@legalsylvain could you rebase on 8.0 please?

…tion;

… context;

…anRijnhart

…anRijnhart;

…nly called at the installation, and no during update anymore;

…quired;

…odel;j

legalsylvain · 2015-09-22T16:18:53Z

@rvalyi : done.

…classification 8.0 ref port account product fiscal classification

legalsylvain added the work in progress label Sep 8, 2015

danimaribeiro reviewed Sep 8, 2015
View reviewed changes

legalsylvain added needs review 8.0 and removed work in progress labels Sep 8, 2015

legalsylvain reviewed Sep 8, 2015
View reviewed changes

danimaribeiro reviewed Sep 8, 2015
View reviewed changes

legalsylvain mentioned this pull request Sep 8, 2015

[ADD] product taxes group that replace account_product_fiscal_classification #24

Closed

mileo reviewed Sep 10, 2015
View reviewed changes

mileo mentioned this pull request Sep 10, 2015

[8.0] Port account_fiscal_position_rule_purchase module #26

Closed

legalsylvain added 5 commits September 22, 2015 18:18

[ADD] module product_taxes_group;

dc7269b

[IMP] apply fixes from akretion;

b83e46e

[REF] rename module 1/2;

dd65f95

[REF] rename module 2/2;

fad924c

[REF] renaming model;

85f447b

legalsylvain added 13 commits September 22, 2015 18:18

[REF] renaming model (2/2);

2002e1d

[REF] change function name according to the new objective of the func…

4be2d91

…tion;

[ADD] add demo data and change rules to manage and test multi company…

1eab7e8

… context;

[REF]

c9b2189

[REF] remove unported folder;

9cb720f

[REF] move init function into 'post_init_hook' part. courtesy : @Stef…

d71fb29

…anRijnhart;

[REF] use new API; Remove useless code, as the init function is now o…

59c7530

…nly called at the installation, and no during update anymore;

[FIX] bad path for screenshots;

436f302

[FIX] flake8;

a04ef67

[REF] improve comments about how classification_id field is set as re…

80b3068

…quired;

[ADD] pot file ; fr translation file ; set name field as translatable;

ca087bb

[MRG] add pt_BR.po file;

cd25f50

[ADD] code and description on account_product_fiscal_classification m…

0c7dafa

…odel;j

legalsylvain force-pushed the 8.0_REF_PORT_account_product_fiscal_classification branch from 5743141 to 0c7dafa Compare September 22, 2015 16:18

rvalyi added a commit that referenced this pull request Sep 22, 2015

Merge pull request #28 from grap/8.0_REF_PORT_account_product_fiscal_…

7f2db78

…classification 8.0 ref port account product fiscal classification

rvalyi merged commit 7f2db78 into OCA:8.0 Sep 22, 2015

yvaucher removed the needs review label Sep 22, 2015

legalsylvain added a commit to grap/odoo-addons-misc that referenced this pull request Sep 23, 2015

[REF] OCA/account-fiscal-rule#28;

15934da

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8.0 ref port account product fiscal classification #28

8.0 ref port account product fiscal classification #28

legalsylvain commented Sep 8, 2015

danimaribeiro Sep 8, 2015

legalsylvain commented Sep 8, 2015

legalsylvain Sep 8, 2015

legalsylvain commented Sep 8, 2015

danimaribeiro Sep 8, 2015

legalsylvain Sep 8, 2015

danimaribeiro Sep 8, 2015

danimaribeiro commented Sep 8, 2015

rvalyi commented Sep 8, 2015

legalsylvain commented Sep 9, 2015

danimaribeiro commented Sep 9, 2015

mileo Sep 10, 2015

legalsylvain Sep 10, 2015

mileo Sep 14, 2015

mileo commented Sep 10, 2015

legalsylvain commented Sep 10, 2015

renatonlima commented Sep 10, 2015

danimaribeiro commented Sep 10, 2015

legalsylvain commented Sep 10, 2015

legalsylvain commented Sep 15, 2015

renatonlima commented Sep 18, 2015

legalsylvain commented Sep 21, 2015

rvalyi commented Sep 22, 2015

legalsylvain commented Sep 22, 2015

		all the taxes;

		.. image:: ./static/src/img/product_template_accounting_setting.png

8.0 ref port account product fiscal classification #28

8.0 ref port account product fiscal classification #28

Conversation

legalsylvain commented Sep 8, 2015

Choose a reason for hiding this comment

legalsylvain commented Sep 8, 2015

Choose a reason for hiding this comment

legalsylvain commented Sep 8, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

danimaribeiro commented Sep 8, 2015

rvalyi commented Sep 8, 2015

legalsylvain commented Sep 9, 2015

danimaribeiro commented Sep 9, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mileo commented Sep 10, 2015

legalsylvain commented Sep 10, 2015

renatonlima commented Sep 10, 2015

danimaribeiro commented Sep 10, 2015

legalsylvain commented Sep 10, 2015

legalsylvain commented Sep 15, 2015

renatonlima commented Sep 18, 2015

legalsylvain commented Sep 21, 2015

rvalyi commented Sep 22, 2015

legalsylvain commented Sep 22, 2015