[ADD] product taxes group that replace account_product_fiscal_classification #24

legalsylvain · 2015-06-15T13:31:55Z

The module 'product_taxes_group' manages taxes classification like 'account_product_fiscal_classification' but with many2one field (instead of property).
You can read a whole comparison between the two modules here : Ref : OCA/account-financial-tools#32

@rvalyi : I'm waiting for your review.

…on_rule_migration_8.0 Feature/account fiscal position rule migration 8.0

Separated Lint tests

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Follow OCA/maintainer-quality-tools#187 and use addons/apt/package directive to install our build dependencies. This allows using container based Travis builds (which should be faster).

legalsylvain · 2015-07-05T14:09:20Z

Ping. CC : @rvalyi, @sebastienbeau.

use sudo: false to enable container build use cache: pip to cache pip packages

danimaribeiro · 2015-09-07T18:34:12Z

Hey, in the other discussion you told:
"close this V7 PR. In V7, 'account_product_fiscal_classification' is the official one ;
realize a new PR in V8, (as said 'account_product_fiscal_classification' is unported) keeping my code, but renaming module, fields and classes by the name used in account_product_fiscal_position' as much as possible."

Is it possible for you to change the names?
There are a lot of code here in Brazil that depends on the old module:
https://github.com/odoo-brazil/l10n-brazil/blob/8.0/l10n_br_account_product/account_product_fiscal_classification_view.xml
https://github.com/odoo-brazil/l10n-brazil/blob/8.0/l10n_br_account_product/account_product_fiscal_classification.py

We ported to v8 here: https://github.com/odoo-brazil/account-fiscal-rule

legalsylvain · 2015-09-07T19:51:30Z

Hi, since 3 months I didn't receive any review. If you're interested to review it, yes I'll do the according changes I mentionned.

Regards.

danimaribeiro · 2015-09-07T20:19:39Z

product_taxes_group/model/tax_group.py

+    """Group of customer and supplier taxes.
+    This group is linked to a product to select a group of taxes in one
+    time."""
+    _name = 'tax.group'


'account.product.fiscal.classification'

…ile; [ADD] product_taxes_group : add screenshot;

[ADD] product_taxes_group : screenshot;

…ount-fiscal-rule into 8.0_product_taxes_group

legalsylvain · 2015-09-08T12:21:44Z

Oups, I did it again. (bad rebase).

danimaribeiro · 2015-09-08T12:44:35Z

@legalsylvain I sent to your branch the portuguese translations to this module.
If you don't have time, I can change the names and test it here.

legalsylvain · 2015-09-08T12:54:10Z

Hi @danimaribeiro. No thanks, I'm working on that.
I'll realize the following changes :
-> module name changes ;
-> class name changes ;
-> field name changes, except
product_template.property_fiscal_classification --> product_template.fiscal_classification because, it is not a property.
If you want to glue this new module, with your module, you can create a glue module with a field property_fiscal_classification related to field fiscal_classification.

Keep in touch.

Kind regards and thanks for your review.

danimaribeiro · 2015-09-08T12:58:59Z

It sounds good.

legalsylvain · 2015-09-08T20:51:46Z

Duplicate with #28. I close this PR.
Kind regards.

rvalyi and others added 30 commits August 6, 2014 15:20

v8 Travis-CI settings for now

5b39bf3

prepare creation of 8.0 branch

3e47545

mark all addons as unported

39702a5

added web_context_tunnel dependency

b3b74d8

migrated core objects to new Odoo API

71e7d5a

migrated core views

3b192d3

migrated inherited objects to new Odoo API

cbc0fa2

migrated inherited views

e7584a5

Updated pt_BR translations

2ec0ecc

Rebase and PEP8

949533c

Fix method fiscal_position_map to add **kwargs

f4784fd

Added **kwargs in _map_domain method

ca9afc8

set installable

10dbc5b

removed empty XML file

c55c15e

XML format: 2 spaces indents

0d77895

removed char size param; simplified code

5e27878

added some tests

f7f129f

removed empty XML file

4357382

in fact there is no web_context_tunnel dependency at this level

4d37785

also removed old XML view from __openerp__.py

234613e

Merge pull request OCA#10 from akretion/feature/account_fiscal_positi…

5cb701b

…on_rule_migration_8.0 Feature/account fiscal position rule migration 8.0

Separated Lint tests

128d140

Remove deprecated travis_run_flake8

bdbe3d9

[LINT]

6767195

Merge pull request OCA#14 from yvaucher/8.0-separate-lint

6c1a83a

Separated Lint tests

Add OCA as author of OCA addons

ce3ab21

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

don't use travis container-based infrastructure

cfc15d2

Update travis configuration

cefd3fa

Follow OCA/maintainer-quality-tools#187 and use addons/apt/package directive to install our build dependencies. This allows using container based Travis builds (which should be faster).

[WIP] add unported V7 modules 'product_taxes_group';

488a4d8

[FIX] 'product_taxes_group' adapt module to V8;

5639b9a

gurneyalex and others added 4 commits July 24, 2015 22:56

Update travis configuration

557a726

use sudo: false to enable container build use cache: pip to cache pip packages

Forward port changes from 7.0 into 8.0

eecc2e5

Activate transifex and update meta files

2dd4a63

Add codeclimate settings

182fccb

legalsylvain mentioned this pull request Sep 4, 2015

[ADD] new module 'product_taxes_group' OCA/account-financial-tools#32

Closed

danimaribeiro reviewed Sep 7, 2015
View reviewed changes

legalsylvain added 11 commits September 8, 2015 14:14

[WIP] add unported V7 modules 'product_taxes_group';

54a7017

[FIX] 'product_taxes_group' adapt module to V8;

22a9a33

[ADD] 'product_taxes_group' : demo data;

502db94

[REF] 'product_taxes_group' use new API;

825bcc9

[REF] product_taxes_group : move description from openerp to readme f…

d0d2024

…ile; [ADD] product_taxes_group : add screenshot;

[FIX] readme file;

1e3c809

[FIX] readme file;

9144b5e

[REF] product_taxes_group : use new V8 button ;

2ebc66b

[ADD] product_taxes_group : screenshot;

[FIX] image url

b145273

[FIX] spelling;

96635b7

Merge branch '8.0_product_taxes_group' of https://github.com/grap/acc…

377f251

…ount-fiscal-rule into 8.0_product_taxes_group

legalsylvain mentioned this pull request Sep 8, 2015

8.0 ref port account product fiscal classification #28

Merged

legalsylvain closed this Sep 8, 2015

yvaucher removed the needs review label Sep 8, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] product taxes group that replace account_product_fiscal_classification #24

[ADD] product taxes group that replace account_product_fiscal_classification #24

legalsylvain commented Jun 15, 2015

legalsylvain commented Jul 5, 2015

danimaribeiro commented Sep 7, 2015

legalsylvain commented Sep 7, 2015

danimaribeiro Sep 7, 2015

legalsylvain commented Sep 8, 2015

danimaribeiro commented Sep 8, 2015

legalsylvain commented Sep 8, 2015

danimaribeiro commented Sep 8, 2015

legalsylvain commented Sep 8, 2015

[ADD] product taxes group that replace account_product_fiscal_classification #24

[ADD] product taxes group that replace account_product_fiscal_classification #24

Conversation

legalsylvain commented Jun 15, 2015

legalsylvain commented Jul 5, 2015

danimaribeiro commented Sep 7, 2015

legalsylvain commented Sep 7, 2015

danimaribeiro Sep 7, 2015

Choose a reason for hiding this comment

legalsylvain commented Sep 8, 2015

danimaribeiro commented Sep 8, 2015

legalsylvain commented Sep 8, 2015

danimaribeiro commented Sep 8, 2015

legalsylvain commented Sep 8, 2015