-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8.0 account_invoice_merge fixes #220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in local.
LGTM!!
This commit fixes a bug merging invoices that ocurrs when the invoices have been generated from a partial picking. I think this comit could be merged, what's the problem? |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Luc! Did a code review, installed it and checked the tests on a fresh db, and played around with the invoice merge on a db with real data.
LGTM
Conflicts must be solved before merging. |
b3a9cce
to
c17b905
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changes after resolving conflicts.
073ee8a
to
516977e
Compare
516977e
to
952c545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this after a while.
This PR contains a couple of fixes and extra units tests for the account_invoice_merge modules: