Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge invoices do not work due to commit f333de21ce2878b40f2e5729d8c216c9d9303f07 #235

Closed
geekobi opened this issue Mar 13, 2017 · 2 comments
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.

Comments

@geekobi
Copy link

geekobi commented Mar 13, 2017

Hi,
the commit ( @luc-demeyer luc-demeyer committed with pedrobaeza on 21 Jan, f333de2)
changed the return value of do_merge(...) from account_invoice_merge/models/account_invoice.py :

It was : return invoices_info
and it becomed : return invoices_info, invoice_lines_info
(last line : 221)

but, account_invoice_merge/wizard/invoice_merge.py in merge_invoices(self) line 87 calls it

allinvoices = invoices.do_merge(keep_references=self.keep_references,
                                    date_invoice=self.date_invoice)

and remained unchanged

I fixed the issue in probably dirty way by doing

(allinvoices, dummy) = invoices.do_merge(keep_references=self.keep_references,
                                    date_invoice=self.date_invoice)

but, as I am quite new in odoo
also because there is a big PR (8.0 account_invoice_merge fixes #220)
It prefer not going too far and push only an issue

@luc-demeyer
Copy link

@geekobi
PR #220 fixes it, hence it's best that you run with that code until this PR is merged.

@github-actions
Copy link

github-actions bot commented Mar 6, 2022

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

No branches or pull requests

2 participants