-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README to correct runbot address + figure #13
Conversation
not sure why the travis is failing (Transifex password) and seems unrelated ( @moylop260 @gurneyalex @dreispt ) |
Transifex is not setup for this repo, and I'm not sure about the proper process for that. |
You need to follow the instructions in the .travis.yml itself for generating the secret: https://github.com/OCA/maintainer-quality-tools/blob/master/sample_files/.travis.yml#L37-L41 |
thanks all: we will proceed with transifex setup in separate PR. |
But I see the preview and it's not working... |
👍 |
Maybe I am doing something wrong but I was told to include the name of the module in the path so that Odoo can properly display the rst. |
In this PR is just the opposite: OCA/server-tools#456 |
@pedrobaeza you are right and now I am confused... |
Anyway: just let me know and I will adapt the PR according but now I dont know which rule to follow |
The correct seems to be the other way. |
OK: I will remove the full path and adapt the PR. |
1 similar comment
@pedrobaeza @dreispt we can move on |
👍 |
1 similar comment
+1 |
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
[FIX] business_requirement: Update README to correct runbot address + figure
Coverage remained the same at 90.431% when pulling 696304b on 8.0-brd-readme into 843f438 on 8.0.
For now, the Transifex build should be disabled from the
.travis.yml
.Can I have your approval for this one as this is unrelated?
With the name of the module, my editor doesnot display it but it is properly displayed in the application
There was a discussion with @jbeficent about the topic but cannot remember where.
standard rst is upper directory only and I was suggested to add the module name as well and indeed the module display properly in Odoo with the later option (but not in rst/github...)
Coverage remained the same at 90.431% when pulling 7b88ba1 on 8.0-brd-readme into 843f438 on 8.0.