[MIG]Migrated Business requirement module from 8.0 to 10.0 #223

YogeshMahera-SerpentCS · 2017-07-26T07:24:34Z

#48

Migrated Business Requirement from v8 to v10

YogeshMahera-SerpentCS · 2017-07-26T09:16:04Z

@elicoidal @victormartinelicocorp
Please review it.

victormmtorres · 2017-07-26T10:13:57Z

@elicoidal Should we keep this open to include demo data from #212 ?

elicoidal · 2017-07-26T10:18:39Z

@victormartinelicocorp We will merge the PR in v8 in short so that we can push forward

elicoidal

LGTM.
Demo data to be added once merged in v8.
README to be updated.
Functional test to be done

elicoidal · 2017-07-26T10:36:40Z

Coverage is low: let's try to bring it up to 90% at least

elicoidal · 2017-07-27T13:45:07Z

Looks like a first good start. Some small issues to be corrected:

when creating a BR, the focus is in the use case field. should be in name
only graph view available: pivot should be added as well
there is no report available: at the basic one should be available (Business Requirement Report)
Source field is too wide: could it be set as one size high (now it seems 2)

elicoidal · 2017-07-27T14:53:51Z

It is strange: normally changing the stages is done by clicking on the stage itself (latest developments) but it seems that the buttons are back in this version.
@YogeshMahera-SerpentCS can you check it?

elicoidal · 2017-07-27T23:01:02Z

A new request: I want that some of the modules appear as Application in the list:

create a "Business Requirement" Application
set the following modules as Apps: Business Requirement, Business Requirement Deliverable and Business Requirement Project

elicoidal · 2017-07-27T23:03:11Z

Source Field should be set as read-only as of Confirmed state (to be backported to v8 too)

YogeshMahera-SerpentCS · 2017-07-28T07:09:39Z

only graph view available: pivot should be added as well

Which field should be added in pivot view or same graph view fields?

there is no report available: at the basic one should be available (Business Requirement Report)

In v8 there is no report like Business Requirement Report, so if is it require then what should be format?.

@elicoidal

elicoidal · 2017-07-28T07:13:33Z

@YogeshMahera-SerpentCS

Which field should be added in pivot view or same graph view fields?

When I install the modules in v8, I have a pivot view for the "Business Requirement". Maybe it is defined in another module. Please check current Odoo 8 version

In v8 there is no report like Business Requirement Report, so if is it require then what should be format?.

Yes there is: please check current Odoo 8 version

YogeshMahera-SerpentCS · 2017-07-28T07:46:37Z

When I install the modules in v8, I have a pivot view for the "Business Requirement". Maybe it is defined in another module. Please check current Odoo 8 version

Yes, I see in v10 there is pivot view is itself record view. In v8 it's included in graph view type as pivot.

Yes there is: please check current Odoo 8 version

Yes, it's available in business_requirement_deliverable_report.so shall I copy from business_requirement_deliverable_report to business_requirement module.?

@elicoidal

elicoidal · 2017-07-28T10:02:13Z

Yes: the one for BR should be moved here and the one for deliverable in br_deliverable and the one for cost in brd_cost module
We should have done it in v8... but it is OK

YogeshMahera-SerpentCS · 2017-07-31T06:21:49Z

@elicoidal

It is strange: normally changing the stages is done by clicking on the stage itself (latest developments) but it seems that the buttons are back in this version.
@YogeshMahera-SerpentCS can you check it?

Yes, I have checked its code in business_requirement_deliverable_project.
so shall I do stage as itself clicking in BR main module?

elicoidal · 2017-07-31T07:55:39Z

@YogeshMahera-SerpentCS Please fix v8 and we will forward port to v10 for the sake of consistency

seb-elico

Small indentation issues

seb-elico · 2017-08-14T06:21:03Z

business_requirement/report/report.xml

+<?xml version="1.0" encoding="utf-8"?>
+<odoo>
+    <report
+            id="business_requirement_report"


First parameter should be on the same line as the tag

seb-elico · 2017-08-14T06:22:51Z

business_requirement/views/business_view.xml

+                    </div>
+                    <div class="oe_right oe_button_box"
+                         name="buttons" groups="base.group_user">
+                         <button class="oe_inline oe_stat_button"


Over-indented of 1 space

seb-elico · 2017-08-14T06:23:35Z

business_requirement/views/business_view.xml

+                    <notebook>
+                        <page string="Business Requirement">
+                            <group string="Customer Story">
+                                 <field name="business_requirement" nolabel="1"/>


All field tags below are over-indented of 1 space

seb-elico · 2017-08-14T06:24:43Z

business_requirement/views/business_view.xml

+            <form string="Business Requirement">
+                <sheet>
+                    <group>
+                         <field name="name"/>


Over-indented

seb-elico · 2017-08-14T06:25:03Z

business_requirement/views/business_view.xml

+        <field name="priority">20</field>
+        <field name="arch" type="xml">
+            <tree string="Business Requirement">
+                 <field name="name"/>


Over-indented

YogeshMahera-SerpentCS · 2017-08-14T06:54:06Z

@seb-elico Improved Changes

seb-elico

LGTM

victormmtorres · 2017-08-14T07:17:58Z

@YogeshMahera-SerpentCS as is not clear then here is the work expected on UT:

Refactor UT from: business_requirement/tests/test_project.py:

Fix name of file as is not true because all test are based on br object nothing is tested on project.
Extract all test inside the setUp function (setUp is just a common part for each test).

Refactor UT from: business_requirement/tests/test_br.py

Check every function on b-r object and be sure to create the test for every condition.
Follow example done on:
- def test_create_name_equal_slash(self)
- def test_create_write_project(self):

elicoidal · 2017-08-14T10:34:14Z

@YogeshMahera-SerpentCS let's try to finish it today 😄

YogeshMahera-SerpentCS · 2017-08-14T10:37:24Z

@elicoidal Yes, I am doing my best.
Almost completed.

YogeshMahera-SerpentCS · 2017-08-14T11:49:12Z

@victormartinelicocorp Can you please review

victormmtorres

Let's move forward. The rest of UT to be improved on the next batch.

bistaray · 2017-08-26T21:09:47Z

After installing this as the first module on a new 10.0 Enterprise Edition database (no errors during installation), I can create a Category, but when I try to create a Business Requirement, I get:

TypeError: Cannot read property '0' of undefined

And am blocked from proceeding, even after this message is dismissed.

elicoidal · 2017-08-29T01:39:40Z

@bistaray thanks for reporting: I could not reproduce the error.
I created a new category and then tried to create a BR and did not experience any issue.
Do you have a pattern to reproduce it? Could you input an issue if you can reproduce it with the steps?
Thanks!

vcloud9ray · 2017-09-02T23:14:30Z

@elicoidal - I pulled the latest version of Odoo 10 Community + Enterprise and re-downloaded the repo. Now I can create a BR without the error. So whatever my issue was, it is gone now. (bistaray -> vcloud9raymond)

elicoidal · 2017-09-03T07:30:15Z

@vcloud9raymond Great! thanks for reporting back

* [MIG]Migrated Business requirement module from 8.0 to 10.0 * [FIX]Fix Pylint * [IMP]Added new blankline in security file * [IMP]Added Test-Cases for Coverage * [IMP]Added report,improved fields in py and xml * [IMP]Improved code * [IMP] Removed default dimensions from pivot view * [FIX]Fixed Pylint * [IMP]Improved code * [IMP]Improved code * [FIX]Fixed Travis * [IMP]Test-cases Improved * [IMP]Improved view as per OCA standards * [IMP]Improved assert in test-cases * [IMP]-Added assertEqual in test-cases * [IMP]Improved Test-cases * [IMP]Improved Code as per OCA Standard in XML * [IMP/REM]Cover whole BR-code and removed unnecessary test-cases. * [IMP]Cover test-cases default_comany function

[MIG]Migrated Business requirement module from 8.0 to 10.0

fdd3687

YogeshMahera-SerpentCS force-pushed the 10.0-MIG-Business_requirement branch from 3a4fa78 to f3a764a Compare July 26, 2017 07:50

[FIX]Fix Pylint

9b9a03e

YogeshMahera-SerpentCS force-pushed the 10.0-MIG-Business_requirement branch from f3a764a to 9b9a03e Compare July 26, 2017 07:56

sudhir-serpentcs mentioned this pull request Jul 26, 2017

[MIG]-Migrated Business Requirement Deliverable from 8.0 to 10.0. #224

Merged

[IMP]Added new blankline in security file

4f41722

YogeshMahera-SerpentCS force-pushed the 10.0-MIG-Business_requirement branch from 714b739 to 4f41722 Compare July 26, 2017 10:10

elicoidal reviewed Jul 26, 2017

View reviewed changes

[IMP]Added Test-Cases for Coverage

33c348a

YogeshMahera-SerpentCS mentioned this pull request Jul 27, 2017

[MIG]-Migrated Business requirement deliverable cost module from 8.0 t… #225

Merged

pedrobaeza mentioned this pull request Jul 27, 2017

Migration to version 10.0 [FINISHED] #48

Closed

14 tasks

elicoidal added the work in progress label Jul 27, 2017

elicoidal added this to the 10.0 milestone Jul 27, 2017

YogeshMahera-SerpentCS added 3 commits July 28, 2017 16:49

[IMP]Added report,improved fields in py and xml

2d660d8

Merge branch '10.0' into 10.0-MIG-Business_requirement

8794a42

[IMP]Improved code

77e2302

seb-elico suggested changes Aug 14, 2017

View reviewed changes

[IMP]Improved Code as per OCA Standard in XML

09b418c

seb-elico approved these changes Aug 14, 2017

View reviewed changes

[IMP/REM]Cover whole BR-code and removed unnecessary test-cases.

3e83abd

YogeshMahera-SerpentCS force-pushed the 10.0-MIG-Business_requirement branch from b1472df to 3e83abd Compare August 14, 2017 10:08

[IMP]Cover test-cases default_comany function

8c6b15c

YogeshMahera-SerpentCS force-pushed the 10.0-MIG-Business_requirement branch from 9d974fd to 8c6b15c Compare August 14, 2017 11:15

victormmtorres approved these changes Aug 15, 2017

View reviewed changes

elicoidal merged commit 1ef4256 into OCA:10.0 Aug 15, 2017

This was referenced Sep 13, 2017

[10.0]-[MIG]-Migrated business_requirement_earned_value from v8 to v10 #234

Closed

[IMP] business_requirement_etherpad #244

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG]Migrated Business requirement module from 8.0 to 10.0 #223

[MIG]Migrated Business requirement module from 8.0 to 10.0 #223

YogeshMahera-SerpentCS commented Jul 26, 2017 •

edited

Loading

YogeshMahera-SerpentCS commented Jul 26, 2017

victormmtorres commented Jul 26, 2017

elicoidal commented Jul 26, 2017

elicoidal left a comment

elicoidal commented Jul 26, 2017

elicoidal commented Jul 27, 2017 •

edited

Loading

elicoidal commented Jul 27, 2017

elicoidal commented Jul 27, 2017 •

edited

Loading

elicoidal commented Jul 27, 2017 •

edited

Loading

YogeshMahera-SerpentCS commented Jul 28, 2017

elicoidal commented Jul 28, 2017

YogeshMahera-SerpentCS commented Jul 28, 2017 •

edited

Loading

elicoidal commented Jul 28, 2017

YogeshMahera-SerpentCS commented Jul 31, 2017

elicoidal commented Jul 31, 2017

seb-elico left a comment

seb-elico Aug 14, 2017

seb-elico Aug 14, 2017

seb-elico Aug 14, 2017

seb-elico Aug 14, 2017

seb-elico Aug 14, 2017

YogeshMahera-SerpentCS commented Aug 14, 2017

seb-elico left a comment

victormmtorres commented Aug 14, 2017

elicoidal commented Aug 14, 2017

YogeshMahera-SerpentCS commented Aug 14, 2017

YogeshMahera-SerpentCS commented Aug 14, 2017

victormmtorres left a comment

bistaray commented Aug 26, 2017

elicoidal commented Aug 29, 2017

vcloud9ray commented Sep 2, 2017 •

edited

Loading

elicoidal commented Sep 3, 2017

[MIG]Migrated Business requirement module from 8.0 to 10.0 #223

[MIG]Migrated Business requirement module from 8.0 to 10.0 #223

Conversation

YogeshMahera-SerpentCS commented Jul 26, 2017 • edited Loading

YogeshMahera-SerpentCS commented Jul 26, 2017

victormmtorres commented Jul 26, 2017

elicoidal commented Jul 26, 2017

elicoidal left a comment

Choose a reason for hiding this comment

elicoidal commented Jul 26, 2017

elicoidal commented Jul 27, 2017 • edited Loading

elicoidal commented Jul 27, 2017

elicoidal commented Jul 27, 2017 • edited Loading

elicoidal commented Jul 27, 2017 • edited Loading

YogeshMahera-SerpentCS commented Jul 28, 2017

elicoidal commented Jul 28, 2017

YogeshMahera-SerpentCS commented Jul 28, 2017 • edited Loading

elicoidal commented Jul 28, 2017

YogeshMahera-SerpentCS commented Jul 31, 2017

elicoidal commented Jul 31, 2017

seb-elico left a comment

Choose a reason for hiding this comment

seb-elico Aug 14, 2017

Choose a reason for hiding this comment

seb-elico Aug 14, 2017

Choose a reason for hiding this comment

seb-elico Aug 14, 2017

Choose a reason for hiding this comment

seb-elico Aug 14, 2017

Choose a reason for hiding this comment

seb-elico Aug 14, 2017

Choose a reason for hiding this comment

YogeshMahera-SerpentCS commented Aug 14, 2017

seb-elico left a comment

Choose a reason for hiding this comment

victormmtorres commented Aug 14, 2017

elicoidal commented Aug 14, 2017

YogeshMahera-SerpentCS commented Aug 14, 2017

YogeshMahera-SerpentCS commented Aug 14, 2017

victormmtorres left a comment

Choose a reason for hiding this comment

bistaray commented Aug 26, 2017

elicoidal commented Aug 29, 2017

vcloud9ray commented Sep 2, 2017 • edited Loading

elicoidal commented Sep 3, 2017

YogeshMahera-SerpentCS commented Jul 26, 2017 •

edited

Loading

elicoidal commented Jul 27, 2017 •

edited

Loading

elicoidal commented Jul 27, 2017 •

edited

Loading

elicoidal commented Jul 27, 2017 •

edited

Loading

YogeshMahera-SerpentCS commented Jul 28, 2017 •

edited

Loading

vcloud9ray commented Sep 2, 2017 •

edited

Loading