Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG]-Migrated Business Requirement Deliverable from 8.0 to 10.0. #224

Merged

Conversation

sudhir-serpentcs
Copy link
Contributor

Issue #48

Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Will wait for dependency before tests

@elicoidal
Copy link
Contributor

@sudhir-serpentcs I think I have not seen the printout from #232

@elicoidal
Copy link
Contributor

Please make sure to set this module as Apps (#223 (comment))

@sudhir-serpentcs
Copy link
Contributor Author

@elicoidal , Now 'Business Requirement Deliverable' module is set as Apps.

@elicoidal
Copy link
Contributor

@sudhir-serpentcs Could you please rebase as #223 is now merged?

@sudhir-serpentcs sudhir-serpentcs force-pushed the 10.0-MIG-Business_requirement_deliverable branch from 591ab49 to bf3470b Compare August 16, 2017 04:27
@YogeshMahera-SerpentCS
Copy link
Member

YogeshMahera-SerpentCS commented Aug 16, 2017

@elicoidal @victormartinelicocorp rebased.

By mistake, I removed all commits from the branch which automatic closed PR.but now retrieved all code and it rebased 😃
Could you please check it?

@elicoidal
Copy link
Contributor

elicoidal commented Aug 16, 2017

  • In runbot, some deliverable products are created 2 times (SER01, SER02, SER03)
  • In deliverable menu there should be pivot view (no dimension by default)
  • In resources menu there should be pivot view (no dimension by default)

@elicoidal
Copy link
Contributor

@victormartinelicocorp @seb-elico can you have a look?

@elicoidal
Copy link
Contributor

elicoidal commented Aug 16, 2017

  • Revenue field in Deliverable Line should be readonly

@elicoidal
Copy link
Contributor

elicoidal commented Aug 16, 2017

  • The smart button display for deliverable should not include decimals (or should use accounting dp)
    screenshot from 2017-08-16 20-14-03

@sudhir-serpentcs
Copy link
Contributor Author

@elicoidal

In runbot, some deliverable products are created 2 times (SER01, SER02, SER03)

I could not able to find the products which were created 2 times on runbot. It would be more helpful if you can provide the steps you followed or can provide the screenshots.

@elicoidal
Copy link
Contributor

elicoidal commented Aug 17, 2017

some additional issues after testing:

  • There is an issue for the product and demo data. For example, product SER03 Consultant is not visible in the menu BR/configuration/product (issue variant/template?). Consultant is still duplicated when selecting in the DL
  • In pivot table, do not add dimensions in Deliverable. To be noted that some measures are in the dimensions (quantity, sales price)
  • Cannot open pivot table in RL (and please remove all dimensions if any)

@elicoidal
Copy link
Contributor

elicoidal commented Aug 17, 2017

  • if a task is procurement type field "assigned to" should be R/O
  • when create a new BR, the focus is on Use case field (was corrected in v8 - strange)

@elicoidal
Copy link
Contributor

elicoidal commented Aug 17, 2017

  • add a space after name and before the "-"
  • in printout if the field is empty do not display (customer story/gap/use case/scenario). ONHOLD to the the html tags
  • My mistake: printout about the RL should be added into this module too
  • I am missing the kanban view for BR
  • graph view for BR is crashing
  • Pivot view for BR: remove the dimensions. Total Revenue should be available as measure
  • in DL/pivot view: there are 3 times dimension "Business Requirement". Adapt the name (Project and Stakeholder)
  • in BR / Tree view: remove Change request. Add Stakeholder (after responsible)
  • Everywhere (fields, filters name etc): change the name "Customer" for "Stakeholder"
  • In RL tree view, Filters: there is 3 times Business Requirement in the list of fields. Same in pivot view. Remove the default dimensions

@elicoidal
Copy link
Contributor

@sudhir-serpentcs Let me know if unclear

@elicoidal
Copy link
Contributor

@sudhir-serpentcs Any news? Main functions are still failing

@elicoidal
Copy link
Contributor

@sudhir-serpentcs Any news?

@elicoidal
Copy link
Contributor

@seb-elico can you have a quick look so that we can move forward?

@YogeshMahera-SerpentCS
Copy link
Member

@elicoidal Sure, thanks for your review and test!

@elicoidal elicoidal merged commit 496be4e into OCA:10.0 Sep 13, 2017
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 6, 2019
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 6, 2019
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 21, 2019
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 21, 2019
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 26, 2019
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jul 25, 2019
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Aug 9, 2019
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Aug 19, 2019
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Jan 27, 2020
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Mar 3, 2020
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Mar 5, 2020
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Mar 30, 2020
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Nov 11, 2021
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Nov 15, 2021
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Nov 15, 2021
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
MosabWadea pushed a commit to MosabWadea/business-requirement that referenced this pull request Mar 5, 2022
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
bizzappdev pushed a commit to BizzAppDev-Systems/business-requirement that referenced this pull request Mar 4, 2023
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
dreispt pushed a commit to dreispt/business-requirement that referenced this pull request Apr 27, 2024
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
dreispt pushed a commit to dreispt/business-requirement that referenced this pull request Apr 27, 2024
…A#224)

* [IMP/ADD]Added business_requirement_deliverable

* [IMP]Improved code

* [IMP]Improved code

* [FIX]Fixed issue of graph view

* [FIX]Fixed issue of graph view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants