Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0]-IMP-Stages as clickable in BR #227

Merged
merged 5 commits into from
Aug 4, 2017
Merged

[8.0]-IMP-Stages as clickable in BR #227

merged 5 commits into from
Aug 4, 2017

Conversation

YogeshMahera-SerpentCS
Copy link
Member

@YogeshMahera-SerpentCS YogeshMahera-SerpentCS commented Jul 31, 2017 •
edited
Loading

#223

  • Stages as clickable in BR main module
  • Removed code unnecessary code.

@YogeshMahera-SerpentCS YogeshMahera-SerpentCS changed the title [8.0]-IMP-Stages as clickable [8.0]-IMP-Stages as clickable in BR Jul 31, 2017
@elicoidal elicoidal added this to the 10.0 milestone Jul 31, 2017
@elicoidal
Copy link
Contributor

Please check travis

@elicoidal elicoidal modified the milestones: 8.0, 10.0 Jul 31, 2017
@YogeshMahera-SerpentCS
Copy link
Member Author

@elicoidal Can you please review.

elicoidal
elicoidal approved these changes Aug 1, 2017
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests OK

@elicoidal
Copy link
Contributor

@victormartinelicocorp @seb-elico

victormmtorres
victormmtorres suggested changes Aug 4, 2017
View reviewed changes
business_requirement/models/business.py
@@ -353,6 +316,74 @@ def message_post(self, cr, uid, thread_id, body='', subject=None,
)
return res

@api.model
def read_group(self, domain, fields, groupby, offset=0,
Copy link
Collaborator

@victormmtorres victormmtorres Aug 4, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YogeshMahera-SerpentCS Add docstring:

  • Short functionality description
  • Input
  • Ouput

seb-elico
seb-elico approved these changes Aug 4, 2017
View reviewed changes
Copy link
Collaborator

@seb-elico seb-elico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after adding docstring

@YogeshMahera-SerpentCS
Copy link
Member Author

@victormartinelicocorp
Added docstring

    """ Read group customization in order to display all the stages in the
        kanban view. if the stages values are there it will group by state.
    """

@elicoidal elicoidal merged commit d312426 into OCA:8.0 Aug 4, 2017
@YogeshMahera-SerpentCS YogeshMahera-SerpentCS deleted the 8.0-IMP-Stage_improvements branch August 4, 2017 09:19
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 15, 2019
@YogeshMahera-SerpentCS
[8.0]-IMP-Stages as clickable in BR (OCA#227)
fe613e0 
* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 22, 2019
@YogeshMahera-SerpentCS
[8.0]-IMP-Stages as clickable in BR (OCA#227)
fc11c18 
* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 4, 2019
@YogeshMahera-SerpentCS
[8.0]-IMP-Stages as clickable in BR (OCA#227)
83c7da0 
* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
pedrobaeza pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 21, 2019
@YogeshMahera-SerpentCS @pedrobaeza
[8.0][IMP]-Improved Origin field (OCA#226)
8ce542e 
* [8.0][IMP]-Improved Origin field

* [IMP]Improved field Type for Origin field

[8.0]-IMP-Stages as clickable in BR (OCA#227)

* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
victormmtorres pushed a commit to Tecnativa/business-requirement that referenced this pull request Jun 26, 2019
@YogeshMahera-SerpentCS
[8.0][IMP]-Improved Origin field (OCA#226)
da0e133 
* [8.0][IMP]-Improved Origin field

* [IMP]Improved field Type for Origin field

[8.0]-IMP-Stages as clickable in BR (OCA#227)

* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
Tardo pushed a commit to Tecnativa/business-requirement that referenced this pull request Jan 24, 2020
@YogeshMahera-SerpentCS @Tardo
[8.0][IMP]-Improved Origin field (OCA#226)
0b8c60d 
* [8.0][IMP]-Improved Origin field

* [IMP]Improved field Type for Origin field

[8.0]-IMP-Stages as clickable in BR (OCA#227)

* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Oct 14, 2021
@YogeshMahera-SerpentCS @victoralmau
[8.0][IMP]-Improved Origin field (OCA#226)
966dd2f 
* [8.0][IMP]-Improved Origin field

* [IMP]Improved field Type for Origin field

[8.0]-IMP-Stages as clickable in BR (OCA#227)

* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
victoralmau pushed a commit to Tecnativa/business-requirement that referenced this pull request Oct 14, 2021
@YogeshMahera-SerpentCS @victoralmau
[8.0][IMP]-Improved Origin field (OCA#226)
4230360 
* [8.0][IMP]-Improved Origin field

* [IMP]Improved field Type for Origin field

[8.0]-IMP-Stages as clickable in BR (OCA#227)

* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
MosabWadea pushed a commit to MosabWadea/business-requirement that referenced this pull request Mar 5, 2022
@YogeshMahera-SerpentCS @MosabWadea
[8.0][IMP]-Improved Origin field (OCA#226)
31835db 
* [8.0][IMP]-Improved Origin field

* [IMP]Improved field Type for Origin field

[8.0]-IMP-Stages as clickable in BR (OCA#227)

* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
AntoniRomera pushed a commit to AntoniRomera/business-requirement that referenced this pull request Jul 4, 2023
@YogeshMahera-SerpentCS
[8.0][IMP]-Improved Origin field (OCA#226)
55d8cb8 
* [8.0][IMP]-Improved Origin field

* [IMP]Improved field Type for Origin field

[8.0]-IMP-Stages as clickable in BR (OCA#227)

* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
NachoAlesLopez pushed a commit to NachoAlesLopez/business-requirement that referenced this pull request Apr 28, 2024
@YogeshMahera-SerpentCS @NachoAlesLopez
[8.0][IMP]-Improved Origin field (OCA#226)
8011344 
* [8.0][IMP]-Improved Origin field

* [IMP]Improved field Type for Origin field

[8.0]-IMP-Stages as clickable in BR (OCA#227)

* [IMP]Added Stages as clickble removed buttons

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [Added docstring in readgroup method]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicoidal elicoidal elicoidal approved these changes

@seb-elico seb-elico seb-elico approved these changes

@victormmtorres victormmtorres victormmtorres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YogeshMahera-SerpentCS @elicoidal @seb-elico @victormmtorres