Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.0]-[MIG]-Migrated module from v8 to v10 Business_requirement_deliverable_project_task_categ #233

Merged
merged 12 commits into from
Oct 27, 2017
Merged

[10.0]-[MIG]-Migrated module from v8 to v10 Business_requirement_deliverable_project_task_categ #233

merged 12 commits into from
Oct 27, 2017

Conversation

YogeshMahera-SerpentCS
Copy link
Member

@YogeshMahera-SerpentCS YogeshMahera-SerpentCS commented Aug 2, 2017 •
edited
Loading

#48

  • Business_requirement_deliverable_project_task_categ

@elicoidal elicoidal added this to the 10.0 milestone Aug 3, 2017
@pedrobaeza pedrobaeza mentioned this pull request Aug 3, 2017
Closed
14 tasks
@YogeshMahera-SerpentCS
Copy link
Member Author

YogeshMahera-SerpentCS commented Aug 3, 2017 •
edited
Loading

Notes:-

  • effective_hours field

  • In v8 that field is available in project module but later on v9 it's moved on project_timesheet,
    now in v10, it's again moved to hr_timesheet.

  • So added hr_timesheet dependency in business_requirement_deliverable_project project.

@sudhir-serpentcs sudhir-serpentcs mentioned this pull request Aug 3, 2017
Merged
@YogeshMahera-SerpentCS
Merge branch '10.0' of https://github.com/OCA/business-requirement in…
dac7053 
…to 10.0-MIG-Business_requirement_deliverable_project_task_categ
@elicoidal
Copy link
Contributor

@YogeshMahera-SerpentCS I tested it but could not find the categories anywhere in the Resources lines. Did I miss something?

@elicoidal
Copy link
Contributor

@YogeshMahera-SerpentCS

@YogeshMahera-SerpentCS
Copy link
Member Author

@elicoidal
I think this PR depends on #231(BR Project module)
So We have to wait for merge.

@elicoidal
Copy link
Contributor

OK: let's try to fix all other PR first 😄

@elicoidal
Copy link
Contributor

I think you can rebase this one as the data model in #231 should be stable now

@YogeshMahera-SerpentCS
Merge branch '10.0' of https://github.com/OCA/business-requirement in…
38f793b 
…to 10.0-MIG-Business_requirement_deliverable_project_task_categ
@YogeshMahera-SerpentCS
Copy link
Member Author

rebased

@elicoidal
Copy link
Contributor

elicoidal commented Oct 5, 2017 •
edited
Loading

should still wait for project to be merged

@YogeshMahera-SerpentCS
Merge branch '10.0' of https://github.com/OCA/business-requirement in…
9fc62b6 
…to 10.0-MIG-Business_requirement_deliverable_project_task_categ
@elicoidal
Copy link
Contributor

@YogeshMahera-SerpentCS can you rebase as #231 is merged so that we can finish this one?

@YogeshMahera-SerpentCS
Copy link
Member Author

@elicoidal rebased

@elicoidal
Copy link
Contributor

Thanks @YogeshMahera-SerpentCS
Seems travis and runbot are both failing: can you have a look?

@victormmtorres
Copy link
Collaborator

@YogeshMahera-SerpentCS

ParseError: "categ_id" while parsing /home/travis/build/OCA/business-requirement/business_requirement_deliverable_project_task_categ/data/business_requirement_deliverable_project_task_categ_demo.xml:20, near

@YogeshMahera-SerpentCS
Copy link
Member Author

Yes I already checked this one in my local it's seems everything OK. but I am going to check deep.

@YogeshMahera-SerpentCS
Copy link
Member Author

@elicoidal @victormartinelicocorp Could you please review it

victormmtorres
victormmtorres suggested changes Oct 26, 2017
View reviewed changes
business_requirement_deliverable_project_task_categ/models/business_requirement_resource.py Outdated


class BusinessRequirementDeliverableCateg(models.Model):
_inherit = "business.requirement.resource"

categ_id = fields.Many2one(
'project.category.main',
'project.tags',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YogeshMahera-SerpentCS Please use this reference and update related:

https://github.com/OCA/project/blob/10.0/project_task_category/models/project_task.py#L14

elicoidal
elicoidal reviewed Oct 26, 2017
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they tests?

@YogeshMahera-SerpentCS
Copy link
Member Author

@victormartinelicocorp Could you please check it

elicoidal
elicoidal approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional tests OK

@elicoidal
Copy link
Contributor

@victormartinelicocorp

victormmtorres
victormmtorres approved these changes Oct 27, 2017
View reviewed changes
Copy link
Collaborator

@victormmtorres victormmtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elicoidal elicoidal merged commit b89fcf4 into OCA:10.0 Oct 27, 2017
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 22, 2019
@YogeshMahera-SerpentCS
[10.0]-[MIG]-Migrated module from v8 to v10 Business_requirement_deli…
afb8c10 
…verable_project_task_categ (OCA#233)

* [MIG]Migrated module from v8 to v10

* [IMP/ADD]Improved code as per v10,Added dependency of hr_timesheet:- effective_hours field moved from project.

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 22, 2019
@YogeshMahera-SerpentCS
[10.0]-[MIG]-Migrated module from v8 to v10 Business_requirement_deli…
6bf5303 
…verable_project_task_categ (OCA#233)

* [MIG]Migrated module from v8 to v10

* [IMP/ADD]Improved code as per v10,Added dependency of hr_timesheet:- effective_hours field moved from project.

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 22, 2019
@YogeshMahera-SerpentCS
[10.0]-[MIG]-Migrated module from v8 to v10 Business_requirement_deli…
01790b5 
…verable_project_task_categ (OCA#233)

* [MIG]Migrated module from v8 to v10

* [IMP/ADD]Improved code as per v10,Added dependency of hr_timesheet:- effective_hours field moved from project.

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code

* [IMP]Improved code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicoidal elicoidal elicoidal approved these changes

@victormmtorres victormmtorres victormmtorres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YogeshMahera-SerpentCS @elicoidal @victormmtorres