Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG]Migrated Business Requirement Deliverable Resource Template Categ from 8.0 to 10.0. #237

Merged
merged 4 commits into from
Oct 30, 2017
Merged

[MIG]Migrated Business Requirement Deliverable Resource Template Categ from 8.0 to 10.0. #237

merged 4 commits into from
Oct 30, 2017

Conversation

sudhir-serpentcs
Copy link
Contributor

@elicoidal elicoidal added this to the 10.0 milestone Aug 4, 2017
elicoidal
elicoidal approved these changes Aug 4, 2017
View reviewed changes
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seb-elico @victormartinelicocorp

@pedrobaeza pedrobaeza mentioned this pull request Aug 4, 2017
Closed
14 tasks
@victormmtorres
Copy link
Collaborator

This PR is depend on #233 , #236
Migrated Business Requirement Deliverable from v8 to

@elicoidal let's wait IMO and then rebase this one

@elicoidal
Copy link
Contributor

Let's wait for the rebase and functional tests

seb-elico
seb-elico approved these changes Aug 9, 2017
View reviewed changes
Copy link
Collaborator

@seb-elico seb-elico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elicoidal
Copy link
Contributor

Waiting for dependencies to be merged and functional tests

@elicoidal
Copy link
Contributor

@sudhir-serpentcs @YogeshMahera-SerpentCS you might want to rebase since #231 is now merged.
Let me know so that I can move forward

@YogeshMahera-SerpentCS
Merge branch '10.0' of https://github.com/OCA/business-requirement in…
f3b3851 
…to 10.0-MIG-Business_requirement_deliverable_resource_template_categ
@victormmtorres
Copy link
Collaborator

@YogeshMahera-SerpentCS Please rebase this PR business_requirement_deliverable_project_task_categ unmet dependency.

@elicoidal
Copy link
Contributor

@YogeshMahera-SerpentCS can you rebase?

@YogeshMahera-SerpentCS
Copy link
Member

@elicoidal @victormartinelicocorp Could you please review

@victormmtorres
Copy link
Collaborator

@YogeshMahera-SerpentCS Did you just rebase, right? So still valid my review.

@elicoidal Can we move forward?

@elicoidal
Copy link
Contributor

All good!

@elicoidal elicoidal merged commit 0dfed3d into OCA:10.0 Oct 30, 2017
ruter-lyu pushed a commit to ruter-lyu/business-requirement that referenced this pull request Mar 22, 2019
@sudhir-serpentcs
[MIG]Migrated Business Requirement Deliverable Resource Template Cate…
72bc918 
…g from 8.0 to 10.0. (OCA#237)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elicoidal elicoidal elicoidal approved these changes

@seb-elico seb-elico seb-elico approved these changes

@victormmtorres victormmtorres victormmtorres approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
10.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sudhir-serpentcs @victormmtorres @elicoidal @YogeshMahera-SerpentCS @seb-elico