[10.0][IMP]-Migrated Business requirement etherpad module from v8 to v10. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elicoidal
approved these changes
Aug 4, 2017
14 tasks
|
@elicoidal I could review it but think would be better as soon #223 is merged so Travis, Coveralls, Runbot are operative. |
seb-elico
suggested changes
Aug 4, 2017
| <field name="model">business.requirement</field> | ||
| <field name="inherit_id" ref="business_requirement.view_business_requirement_form"/> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr='//page[1]' position='after'> |
There was a problem hiding this comment.
- use
"as attribute separator - why using absolute index instead of the tab name?
seb-elico
suggested changes
Aug 9, 2017
| <field name="model">business.requirement</field> | ||
| <field name="inherit_id" ref="business_requirement.view_business_requirement_form"/> | ||
| <field name="arch" type="xml"> | ||
| <xpath expr='//page[@name="logs"]' position='before'> |
There was a problem hiding this comment.
Use " to encapsulate tag parameters
victormmtorres
approved these changes
Aug 9, 2017
ruter-lyu
pushed a commit
to ruter-lyu/business-requirement
that referenced
this pull request
Mar 22, 2019
…v10. (OCA#235) * [IMP]Migrated business requriement etherpad module from v8 to v10 * [IMP]Improved xpath code * [IMP]Improved " to encapsulate tag parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#48