Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] business_requirement_sale: New module in 11.0 #312

Merged
merged 3 commits into from
Jul 12, 2019
Merged

[ADD] business_requirement_sale: New module in 11.0 #312

merged 3 commits into from
Jul 12, 2019

Conversation

victormmtorres
Copy link
Collaborator

@victormmtorres victormmtorres commented Jun 12, 2019 •
edited by pedrobaeza
Loading

This module extends the functionality of Business Requirement Deliverable and to allow you to convert Requirement in new Sale Orders

Depends in

@victormmtorres victormmtorres force-pushed the 11.0-add-business-requirement_deliverable_sale branch 12 times, most recently from 0a6506d to 6ce328b Compare June 13, 2019 16:33
@victormmtorres victormmtorres marked this pull request as ready for review June 13, 2019 16:34
@victormmtorres
Copy link
Collaborator Author

cc @Tecnativa @pedrobaeza @sergio-teruel @Tardo

@victormmtorres victormmtorres force-pushed the 11.0-add-business-requirement_deliverable_sale branch 2 times, most recently from 3d720be to ea1af4d Compare June 14, 2019 09:55
@victormmtorres
Copy link
Collaborator Author

Changes done @Tardo

@rafaelbn rafaelbn added this to the 11.0 milestone Jun 18, 2019
@rafaelbn
Copy link
Member

WIP until #311 is merged. It cannot be tested in runbot

@victormmtorres victormmtorres force-pushed the 11.0-add-business-requirement_deliverable_sale branch from ea1af4d to da4642c Compare June 25, 2019 14:06
@victormmtorres
Copy link
Collaborator Author

rebased @rafaelbn

@victormmtorres victormmtorres force-pushed the 11.0-add-business-requirement_deliverable_sale branch from da4642c to 71381f6 Compare June 27, 2019 15:52
@victormmtorres
Copy link
Collaborator Author

changes done @Tardo

@Tardo
Copy link
Member

Tardo commented Jun 28, 2019

Please, solve linter errors.

@victormmtorres victormmtorres force-pushed the 11.0-add-business-requirement_deliverable_sale branch from 71381f6 to dd4cee9 Compare July 1, 2019 09:46
@victormmtorres
Copy link
Collaborator Author

I rebased

@victormmtorres victormmtorres force-pushed the 11.0-add-business-requirement_deliverable_sale branch from dd4cee9 to 8b838f4 Compare July 1, 2019 14:23
@victormmtorres victormmtorres force-pushed the 11.0-add-business-requirement_deliverable_sale branch 2 times, most recently from 0c6c353 to 0a4aed4 Compare July 7, 2019 23:57
@victormmtorres
Copy link
Collaborator Author

@pedrobaeza All done but this:

Add in the BR chatter a mention that a SO has been created (even putting the embedded link in the message).

This one not sure if could done easy, trace_visibility won't work over One2many fields. Hope I could develop a method soon for it

@victormmtorres
Copy link
Collaborator Author

@pedrobaeza About tracking one2many I found exist a module that should be soon on Odoo v11. Could we move forward and use it as soon this is merged OCA/social#254 it's done?

@pedrobaeza
Copy link
Member

I'm not talking about doing a tracking, but to manually post an entry through message_post method, and you can embed the link in it. Check

https://github.com/odoo/odoo/blob/5c157c57b0c56804576e61f49b431db82ee9fbb7/addons/sale_timesheet/models/sale_order.py#L248-L249

for an example.

@victormmtorres victormmtorres force-pushed the 11.0-add-business-requirement_deliverable_sale branch from 0a4aed4 to 11f50bb Compare July 8, 2019 11:27
@victormmtorres
Copy link
Collaborator Author

Changes done @pedrobaeza

@victormmtorres victormmtorres force-pushed the 11.0-add-business-requirement_deliverable_sale branch from 11f50bb to b000348 Compare July 8, 2019 17:39
@victormmtorres
Copy link
Collaborator Author

Changes done @pedrobaeza

@victormmtorres victormmtorres force-pushed the 11.0-add-business-requirement_deliverable_sale branch from b000348 to 18e6753 Compare July 10, 2019 18:31
@victormmtorres
Copy link
Collaborator Author

Changes done @pedrobaeza

Tardo
Tardo suggested changes Jul 11, 2019
View reviewed changes
business_requirement_sale/models/business.py Outdated Show resolved Hide resolved
business_requirement_sale/models/business.py Outdated Show resolved Hide resolved
business_requirement_sale/models/business.py Outdated Show resolved Hide resolved
business_requirement_sale/models/business.py Outdated Show resolved Hide resolved
business_requirement_sale/models/business.py Outdated Show resolved Hide resolved
business_requirement_sale/wizard/convert_requirement_sale.py Outdated Show resolved Hide resolved
business_requirement_sale/wizard/convert_requirement_sale.py Outdated Show resolved Hide resolved
business_requirement_sale/wizard/convert_requirement_sale.py Outdated Show resolved Hide resolved
business_requirement_sale/wizard/convert_requirement_sale.py Outdated Show resolved Hide resolved
@victormmtorres victormmtorres changed the title [ADD] business_requirement_deliverable_sale: New module in 11.0 [ADD] business_requirement_sale: New module in 11.0 Jul 11, 2019
@pedrobaeza
[IMP] business_requirement_deliverable: Renaming + name_get:
a384842 
* Rename "busines_requirement_deliverable_section_id" to "section_id", as the other long name
  is unmanageable.
* Add name_get method for better BRD naming.
@rafaelbn rafaelbn requested a review from pedrobaeza July 12, 2019 08:39
@pedrobaeza pedrobaeza force-pushed the 11.0-add-business-requirement_deliverable_sale branch from cb2fd5a to d82deb1 Compare July 12, 2019 10:08
@pedrobaeza
[IMP] business_requirement_sale: revamp
044d913 
* Refactorization
* Method optimization
* Tests
* Translations
@pedrobaeza pedrobaeza force-pushed the 11.0-add-business-requirement_deliverable_sale branch from d82deb1 to 044d913 Compare July 12, 2019 11:32
@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Rebased to 11.0-ocabot-merge-pr-312-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 044d913 into OCA:11.0 Jul 12, 2019
OCA-git-bot added a commit that referenced this pull request Jul 12, 2019
@OCA-git-bot
Merge PR #312 into 11.0
4632166 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4632166. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tardo Tardo Tardo requested changes

@sergio-teruel sergio-teruel sergio-teruel requested changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉 needs review
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@victormmtorres @rafaelbn @Tardo @pedrobaeza @OCA-git-bot @sergio-teruel